Add support for Pipedream CLI #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Corresponding blog post: https://rajapri28613.hashnode.dev/1password-shell-plugin-for-pipedream |
arunsathiya
suggested changes
Jul 12, 2023
Contributor
arunsathiya
left a comment
There was a problem hiding this comment.
This looks like a good start, thank you for your contribution @rajapri28613! I have left a few comments to address before we can move forward, including building support for importing multiple profile credentials.
arunsathiya
approved these changes
Jul 19, 2023
Contributor
arunsathiya
left a comment
There was a problem hiding this comment.
Both importer and provisioner work fine. Thanks for the contribution!
SimonBarendse
approved these changes
Jul 25, 2023
Member
SimonBarendse
left a comment
There was a problem hiding this comment.
Appreciate your contribution!
I have left a tiny suggestion for your consideration.
Co-authored-by: Simon Barendse <[email protected]>
accraw
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add support for Pipedream CLI. The shell plugin provisions a configuration file at
~/.config/pipedream/config. The shell plugin also imports the API Key and the Org ID from the same file at the same path, if they exist.Type of change
Related Issue(s)
How To Test
~/.config/pipedream/config, the first timeop plugin init pdis run, the API Key and Org ID can be imported into 1Password.pd login status. It should show that the login is successful.Changelog
Add support for Pipedream CLI
Additional information