[WIP] THREESCALE-10164 Including the env var LARGE_CLIENT_HEADER_BUFFERS#1429
Closed
perylemke wants to merge 2 commits into
Closed
[WIP] THREESCALE-10164 Including the env var LARGE_CLIENT_HEADER_BUFFERS#1429perylemke wants to merge 2 commits into
perylemke wants to merge 2 commits into
Conversation
dfennessy
reviewed
Nov 20, 2023
dfennessy
reviewed
Nov 20, 2023
dfennessy
left a comment
Contributor
There was a problem hiding this comment.
Some minor suggestions to the paragraph.
Adding sugestion. Co-authored-by: Darren Fennessy <[email protected]>
tkan145
requested changes
Dec 20, 2023
tkan145
left a comment
Contributor
There was a problem hiding this comment.
The current code only reads the env var, you will need to also render the value to the apicast.conf.liquid file
For example
diff --git a/gateway/http.d/apicast.conf.liquid b/gateway/http.d/apicast.conf.liquid
index 93d60775..3f1df64c 100644
--- a/gateway/http.d/apicast.conf.liquid
+++ b/gateway/http.d/apicast.conf.liquid
@@ -134,6 +134,10 @@ server {
{% include "http.d/ssl.conf" %}
+ {% if large_client_header_buffers != empty %}
+ large_client_header_buffers {{large_client_header_buffers}};
+ {% endif %}
+
{% for file in "apicast.d/*.conf" | filesystem %}
{% include file %}
{% endfor %}
Member
|
any progress on this issue? |
Member
|
Superseded by #1446 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include
LARGE_CLIENT_HEADER_BUFFERSvar to my first contribution on APICast.Fixes https://issues.redhat.com/browse/THREESCALE-10164