[kbl2vec] Added support for signals conversion.#490
Open
beckerjohannes wants to merge 3 commits into
Open
Conversation
|
RainerGanss
reviewed
Jul 9, 2026
|
|
||
| private List<KblConnection> firstConnectionWithSignal(final KblCoreOccurrence source) { | ||
| return source.getRefConnection().stream() | ||
| .filter(connection -> !Strings.isNullOrEmpty(connection.getSignalName())) |
Collaborator
There was a problem hiding this comment.
A sort is missing here to guarantee determinism.
| private List<KblConnection> firstConnectionWithSignal(final KblGeneralWireOccurrence source) { | ||
| if (source instanceof final KblWireOccurrence wireOccurrence) { | ||
| return wireOccurrence.getRefConnection().stream() | ||
| .filter(connection -> !Strings.isNullOrEmpty(connection.getSignalName())) |
| registry, new ConversionProperties()); | ||
|
|
||
| // Deduplicate signals (and repoint their references) before XML ids are assigned. | ||
| orchestrator.addPostProcessor(new SignalDeduplicationPostProcessor()); |
Collaborator
There was a problem hiding this comment.
I don't like the fact, that we "fix" this in post. Do you see a way where we do this during transformation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
Changes
Description
What
The KBL2VEC converter did not produce any VEC Signals. This adds support for converting KBL connection signal information into a dedicated VEC signal list.
Changes
Design note
Signals are created 1:1 per connection (not deduplicated up front) so the KblConnection → VecSignal entity mapping stays unique and wire→signal linking resolves; duplicates are then merged in the post-processor.
New files
Testing
▎⚠️ Reviewer note: KblToVecConverterTest.snap is regenerated — the diff is large but mechanical (added SignalList document + references).