upgrade for babel 7 #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and made the necessary changes for this plugin to work with babel 7. I think I managed to get everything working correctly, for both babel 6 and 7, so this should continue work for existing babel 6 users.
Summary of changes:
_exports.default
occasionally, so I look for that in addition toexports.default
getRootPath()
doesn't go to the correct root path in babel 7 (which is the error in doesn't work with babel 7 #65). I have modified this to find the correct path for both UMD and everything else@babel/plugin-proposal-export-default-from
for thedefault from
syntax. This results inObject.assign(exports, "default", ...)
, so that needed to be properly detected at the initial traverse. I addedCallExpression()
which closes resembles yourfindExportsInCallExpression()
.should handle duplicated plugin references
: babel 7 throws an error on duplicate plugins so this doesn't even runshould export with babel-plugin-rewire
: babel-plugin-rewire hasn't been upgraded for babel 7 yet, see Babel 7 Support? speedskater/babel-plugin-rewire#209