This repository was archived by the owner on Apr 1, 2024. It is now read-only.
Changed KeyFormatter and derived classes visibility from internal to … #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@vithati Which of these members are critical that you have access to? I'd like to reduce the API you've made public if possible:
|
Owner
|
Or perhaps more appropriately @vithati: what are the use cases you need access to from the library? |
Contributor
Author
|
KeyFormatter.NegotiateSizes and CapiKeyFormatter.IsCapiCompatible is required. Read and write i changed public because if somebody wants get RSAParameters from stream they can use but KeyFormatter.NegotiateSizes and CapiKeyFormatter.IsCapiCompatible required for us. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed KeyFormatter and derived classes visibility from internal to public