Make allowances for session timeout resetting UNION default behaviour#36
Merged
Conversation
users can run this if they are working interactively
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33.
Introduces function
ClickhouseAPI.set_union_default_mode(), which in addition to be called on object initialisation can be called independently. This makes it easier for users running interactively, or otherwise in some script where there may be a long period of non-interaction with the db, to re-set the setting necessary for clustering (and possibly other functions).For now this seems preferable to automatically setting this e.g. every time we execute SQL. But if this proves to be irritating then we can always trigger this function when certain conditions are met.
Additionally to avoid this potentially coming up in tests we change from having
DatabaseAPIfixtures to making them factory fixtures, so that the apis only get instantiated within tests rather than for the lifetime of the fixture.