Fix for splink 4.0.4#37
Merged
Merged
Conversation
Latest update to Splink clustering introduced ambiguities on Clickhouse side, so for now we just manually add necessary aliasing
Avoids new unrelated upstream issue, which will come in Splink 4.0.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newest version of Splink introduced some changes to clustering SQL queries that are not directly compatible with Clickhouse's dialect.
The underlying cause seems to be the same kind of column-name-resolution rules in multi-joins that cause issues with term-frequency adjustments (see #31).
Probably any robust fix requires upstream changes, but for now something that works is string-replacing to manually add aliasing to the offending query. However this is not a good long-term solution (and probably doesn't even qualify as a 'good' short-term solution).
This solution doesn't affect earlier Splink versions so we don't need to bump the minimum version yet.
Also included is a skip of test that fails due to a Splink issue - we can unskip once there is a Splink version containing the fix for that available.