add afl-cmin.py #2413
add afl-cmin.py #2413
Conversation
afl-cmin.py
Outdated
| metavar='file', | ||
| help='location read by the fuzzed program (stdin)') | ||
| group.add_argument( | ||
| '-m', |
There was a problem hiding this comment.
Can you run black to format the python?
There was a problem hiding this comment.
ah wait looks below like you used a formatter(?)
then why is this indentation so weird here?
There was a problem hiding this comment.
it was formatted by yapf. Anyway, I reformatted it using black and the indent looks better.
afl-cmin.py
Outdated
| dest='memory_limit', | ||
| default='none', | ||
| metavar='megs', | ||
| type=lambda x: x if x == 'none' else int(x), |
There was a problem hiding this comment.
-m 0 should probably also be none (right?)
There was a problem hiding this comment.
Both afl-cmin and afl-cmin.bash don't do so. I think it is not bad to keep the old behavior.
There was a problem hiding this comment.
0 and none is the same and it is the default
afl-cmin.py
Outdated
| p = subprocess.Popen(cmd, | ||
| stdout=subprocess.PIPE, | ||
| env=env, | ||
| bufsize=1048576) |
There was a problem hiding this comment.
Maybe the value should be a global/const, especially since you use it twice
There was a problem hiding this comment.
I didn't do so because the value is not so important IMHO.
There was a problem hiding this comment.
I mean you use it twice, it cries for a variable. That way you can also make clear, why you set it to that number
|
IMHO I would move directly for afl-cmin to call afl-cmin.py if afl-cmin.py can be executed successfully. |
done |
|
thanks! |
|
I will make some changes to afl-cmin and also actually install afl-cmin.py on make install ;-) |
I added afl-cmin.py first and didn't replace the awk and bash version yet. Maybe we can switch to python version after more positive feedback from users.