Patch JSON output with kernel filter, MemoryAnalysis plugin #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atches Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
…'s data to output rather than relying on dispatch info which may not always be reliable Signed-off-by: coleramos425 <[email protected]>
…cessed sequentially, causing multiple calls to hipGetDeviceProperties(). To avoid this race condition, skip this call when kernel filtering is being done Signed-off-by: coleramos425 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon testing JSON output support in the MemoryAnalysis plugin I found empty output that would only occur while using the kernel filtering option in omniprobe (i.e.
-k/--kernels). The bug occurred because when kernel filtering is used, Omniprobe could process multiple dispatches at a time, which I'm guessing caused a race condition between multiple handler instances. The easiest solution is to skip the metadata output in this case, which solved the issue for me.This PR also patches an issue in ROCm install in Docker container build where ROCM_VERSION build arg needed to be declared after FROM statement in the Dockerfile for correct scoping. This fixed the issue.