Thanks to visit codestin.com
Credit goes to github.com

Skip to content

When role is UNKNOWN, don't invoke has_role, so don't need to be dep… #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2019
Merged

When role is UNKNOWN, don't invoke has_role, so don't need to be dep… #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions uliweb_apijson/apijson/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ def _get_one(self,key):
params_role = "UNKNOWN"
if params_role not in roles:
return json({"code":400,"msg":"'%s' not accessible by role '%s'"%(modelname,params_role)})
if functions.has_role(request.user,params_role):
if params_role == "UNKNOWN":
permission_check_ok = True
elif functions.has_role(request.user,params_role):
permission_check_ok = True
else:
return json({"code":400,"msg":"user doesn't have role '%s'"%(params_role)})
Expand Down Expand Up @@ -178,7 +180,9 @@ def _get_array(self,key):
params_role = "UNKNOWN"
if params_role not in roles:
return json({"code":400,"msg":"'%s' not accessible by role '%s'"%(modelname,params_role)})
if functions.has_role(request.user,params_role):
if params_role == "UNKNOWN":
permission_check_ok = True
elif functions.has_role(request.user,params_role):
permission_check_ok = True
else:
return json({"code":400,"msg":"user doesn't have role '%s'"%(params_role)})
Expand Down Expand Up @@ -273,7 +277,9 @@ def _head(self,key):
params_role = "UNKNOWN"
if params_role not in roles:
return json({"code":400,"msg":"'%s' not accessible by role '%s'"%(modelname,params_role)})
if functions.has_role(request.user,params_role):
if params_role == "UNKNOWN":
permission_check_ok = True
elif functions.has_role(request.user,params_role):
permission_check_ok = True
else:
return json({"code":400,"msg":"user doesn't have role '%s'"%(params_role)})
Expand Down Expand Up @@ -358,6 +364,9 @@ def _post_one(self,key,tag):
#need OWNER, but don't know how to set user id
return json({"code":400,"msg":"no permission"})
break
elif role == "UNKNOWN":
permission_check_ok = True
break
else:
if functions.has_role(request.user,role):
permission_check_ok = True
Expand Down Expand Up @@ -466,6 +475,9 @@ def _put_one(self,key,tag):
break
else:
return json({"code":400,"msg":"need login user"})
elif role == "UNKNOWN":
permission_check_ok = True
break
else:
if functions.has_role(request.user,role):
permission_check_ok = True
Expand Down Expand Up @@ -564,6 +576,9 @@ def _delete_one(self,key,tag):
break
else:
return json({"code":400,"msg":"need login user"})
elif role == "UNKNOWN":
permission_check_ok = True
break
else:
if functions.has_role(request.user,role):
permission_check_ok = True
Expand Down