Conversation
…lation instructions
…g to the Symfony 2.8 Upgrade instructions
|
@APY/collaborators We may merge this branch. Our project has ready to run with this version ( |
|
What version of the bundle are we going to choose/release? Because I've introduced months ago a list of callbacks instead of a single one, and we have deprecated something for 2.4 |
|
oh great. Let's release it as |
|
@hmert so we need to remove code and deprecation. I'm not sure this is a goos idea because we haven't release a tagged version with this deprecation: users may not be aware about this. What do all collaborators think? |
|
@DonCallisto let's tag, current master as |
|
Well, semantic versioning would suggest us to release a 3.0 version as this is BC (who use symfony 2.3 that was minimum sf version accepted have to upgrade so this seems a BC to me, but I'm not sure). |
|
Thinking it carefully I think that 2.4 is the best choose possible; so change deprecation message to 3.0, group every other BC due to test, refactor and so on. |
|
Ok Here is the plan,
What do you think? @APY/collaborators |
|
Nice plan |
Fix missing service definition
|
@hmert all good except that |
|
|
||
| // Route | ||
| if (null != $config->getRoute()) { | ||
| $this->setRouteUrl($this->router->generate($config->getRoute())); |
There was a problem hiding this comment.
It seems that a parameter is missing from the original PR
was $this->setRouteUrl($this->router->generate($config->getRoute(), $routeParameters));
All credits go to @artscorestudio many thanks 🎉