Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable the Output walkers of Entity with joins (Fixes #931) - #946

Merged
hmert merged 1 commit into
APY:masterfrom
StudioMaX:i931-disable-output-walkers
May 17, 2017
Merged

Disable the Output walkers of Entity with joins (Fixes #931)#946
hmert merged 1 commit into
APY:masterfrom
StudioMaX:i931-disable-output-walkers

Conversation

@StudioMaX

Copy link
Copy Markdown
Contributor

Fix for issue #931
There is another pull request #939 , but it will revert the functionality added by commit #828

@DonCallisto

Copy link
Copy Markdown
Member

@hmert I've seen you merged #828. Can you take a look to this?

@Vowow

Vowow commented May 17, 2017

Copy link
Copy Markdown

Please merge this one

@DonCallisto

Copy link
Copy Markdown
Member

@Vowow Waiting for maintainer of the bundle to check if everything it's ok. I can merge it too but I'm not into all bundle logic and, without test cases, I can't judge if this is good or not.
However I would expected more commitment from new maintainers .... /cc @hmert

@hmert

hmert commented May 17, 2017

Copy link
Copy Markdown
Contributor

@DonCallisto and @Vowow I could not figure out why we're removing walkers. But, in our project. I've tested this PR it looks OK.

@DonCallisto

Copy link
Copy Markdown
Member

@StudioMaX can you explain this change to @hmert ?

@Vowow

Vowow commented May 17, 2017

Copy link
Copy Markdown

@hmert This provide a fix to a bug when you add a manyToOne column to the grid with annotation.
The error is : "The Paginator does not support Queries which only yield ScalarResults. "

@hmert
hmert merged commit d2c4f76 into APY:master May 17, 2017
@StudioMaX

Copy link
Copy Markdown
Contributor Author

@hmert can you release a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants