Updated dependencies for symfony 4 #SymfonyConHackday2017 - #985
Conversation
|
You still need to update the composer.json version constraints 😛 otherwise you get the tests working but installing will not be possible. |
|
@sstok done. |
|
@DonCallisto That is the idea :) |
|
Just saw this PR after checking why no one was able to comment on my issue. What's keeping you guys from merging? |
| SYMFONY_VERSION=2.8.* | ||
| - php: 7.1 | ||
| env: | | ||
| SYMFONY_VERSION=^4.0-beta |
There was a problem hiding this comment.
Could you modify this for symfony 4 (not beta?)
| "require": { | ||
| "php": ">=5.6", | ||
| "symfony/symfony": "~2.8|~3.0", | ||
| "symfony/symfony": "~2.8|~3.0|^4.0-BETA", |
There was a problem hiding this comment.
Thanks! I really love this project!
forking it just to add 5 more characters in composer.json would somehow not be the ideal path to go ;-)
There was a problem hiding this comment.
Of course it isn't but as you can see yourself, in last 12 months or so, I'm the only one who really cares about this project. Sadly I don't have so much free time to dedicate to it
|
Sorry folks, I was travelling. I added the requested changes :) |
|
This introduces no BC breaks, so there is no need for a major revision. However, semantic versioning suggests the following:
|
|
@Jan0707 I personally agree with this, but I was wondering about https://github.com/Jan0707/APYDataGridBundle/blob/29727dfe7f5930f76ef68acfbf203ac29d12b402/composer.json#L31 You can confirm that semver is still respected even when you do a major update like this? |
|
Given that the mentioned dependency is dev only, this should not really matter for releases (As they won't be installed for people that merely use the package, and not actively work on it). |
With best regards from #SymfonyConHackday2017