Thanks to visit codestin.com
Credit goes to github.com

Skip to content

mbed compile : enable flash option with dual core targets #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2020
Merged

mbed compile : enable flash option with dual core targets #964

merged 1 commit into from
Jun 8, 2020

Conversation

jeromecoutant
Copy link
Contributor

mbed compile -m DISCO_H747I_CM4 -t ARM -f
is using mbedls result to detect the correct plugged target on host.

There is an issue with dual core chips,
because 2 different targets exist in the targets.json file for the same HW

Associated patch for mbed test command:
ARMmbed/mbed-os#12630

@MarceloSalazar
@LMESTM

@MarceloSalazar
Copy link
Contributor

@madchutney please check this and share comments.

madchutney
madchutney requested changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@madchutney madchutney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too dangerous, as far as I can see it removes all occurrences of the string from the target meaning that no target can have or can ever have those substrings in the name.

@jeromecoutant
Copy link
Contributor Author

@madchutney we should find something like endswith("_CM4") ?

@jeromecoutant
Copy link
Contributor Author

@madchutney
I applied same kind of change as in ARMmbed/mbed-os#12630

@jeromecoutant
Copy link
Contributor Author

@madchutney thx

@jeromecoutant
Copy link
Contributor Author

ping

@jeromecoutant
Copy link
Contributor Author

Please make a release version with this PR,
as it is needed with ARMmbed/mbed-os#13014

@jeromecoutant
Copy link
Contributor Author

ping

@rwalton-arm rwalton-arm merged commit e385192 into ARMmbed:master Jun 8, 2020
@rwalton-arm rwalton-arm mentioned this pull request Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madchutney madchutney madchutney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeromecoutant @MarceloSalazar @madchutney @rwalton-arm