Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[pull] main from abetlen:main #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2025
Merged

[pull] main from abetlen:main #4

merged 3 commits into from
Mar 12, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Mar 12, 2025 •
edited by sourcery-ai bot
Loading

See Commits and Changes for more details.

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Update llama.cpp to ggml-org/llama.cpp@7841fc7, including adding support for GPT4O and lazy grammar samplers.

New Features:

  • Add support for GPT4O vocabulary pre-type.
  • Introduce lazy grammar sampler with pattern and token triggers.
  • Implement top-n sigma sampling.

@pull pull bot added the ⤵️ pull label Mar 12, 2025
@cr-gpt CR.GPT
Copy link

cr-gpt bot commented Mar 12, 2025

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@pull pull bot merged commit 37eb5f0 into Abaso007:main Mar 12, 2025
@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Mar 12, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the llama.cpp submodule, exposes several new sampler initialization functions, adds GPT4O vocab type, and bumps the package version.

Sequence diagram for llama_sampler_init_top_n_sigma

sequenceDiagram
    participant User
    participant llama_cpp.py
    participant C Library

    User->>llama_cpp.py: Calls llama_sampler_init_top_n_sigma(n)
    llama_cpp.py->>C Library: Calls llama_sampler_init_top_n_sigma(n) (ctypes function)
    C Library-->>llama_cpp.py: Returns llama_sampler_p
    llama_cpp.py-->>User: Returns llama_sampler_p
Loading

Sequence diagram for llama_sampler_init_grammar_lazy_patterns

sequenceDiagram
    participant User
    participant llama_cpp.py
    participant C Library

    User->>llama_cpp.py: Calls llama_sampler_init_grammar_lazy_patterns(vocab, grammar_str, grammar_root, trigger_patterns, num_trigger_patterns, trigger_tokens, num_trigger_tokens)
    llama_cpp.py->>C Library: Calls llama_sampler_init_grammar_lazy_patterns(vocab, grammar_str, grammar_root, trigger_patterns, num_trigger_patterns, trigger_tokens, num_trigger_tokens) (ctypes function)
    C Library-->>llama_cpp.py: Returns llama_sampler_p
    llama_cpp.py-->>User: Returns llama_sampler_p
Loading

Updated class diagram for llama_sampler

classDiagram
    class llama_sampler {
      -struct llama_sampler_i* iface
      -llama_sampler_context_t ctx
    }
    note for llama_sampler "iface is now a const pointer"
Loading

File-Level Changes

Change Details Files
Expose llama_model_n_head_kv function.
  • Added llama_model_n_head_kv function definition.
  • Added llama_model_n_head_kv function binding using ctypes.
 llama_cpp/llama_cpp.py
Expose llama_sampler_init function.
  • Added llama_sampler_init function definition.
  • Added llama_sampler_init function binding using ctypes.
 llama_cpp/llama_cpp.py
Expose llama_sampler_init_top_n_sigma function.
  • Added llama_sampler_init_top_n_sigma function definition.
  • Added llama_sampler_init_top_n_sigma function binding using ctypes.
 llama_cpp/llama_cpp.py
Expose llama_sampler_init_grammar_lazy_patterns function.
  • Added llama_sampler_init_grammar_lazy_patterns function definition.
  • Added llama_sampler_init_grammar_lazy_patterns function binding using ctypes.
 llama_cpp/llama_cpp.py
Update the version of llama.cpp. CHANGELOG.md
llama_cpp/__init__.py
Add GPT4O vocab type.
  • Added LLAMA_VOCAB_PRE_TYPE_GPT4O to the enum.
  • Added LLAMA_VOCAB_PRE_TYPE_GPT4O constant.
 llama_cpp/llama_cpp.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
⤵️ pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abetlen