Implement math builtin frexp, modf, sincos #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illuhad
reviewed
Apr 11, 2023
| @@ -165,7 +166,9 @@ HIPSYCL_BUILTIN T __hipsycl_minmag(T x, T y) noexcept { | |||
|
|
|||
| // Not yet supported | |||
There was a problem hiding this comment.
I think we can remove this comment now :-)
|
Oh accidentally forgot that... Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented frexp, modf and sincos using existing math builtins for hiplike and ze backend.
Re-implementation of sincos is intended for better performance, although haven't benchmarked.
Tested ROCm backend on gfx906, CUDA backend on sm_86; currently I have no access to Intel GPUs, so cannot test ze backend...