[MacOS][Build][OpenMP] Add OpenMP_ROOT to CMakeLists #1427
Conversation
…build for beginners
- src/runtime/CMakeLists.txt: Add a check for APPLE before finding OpenMP - .github/workflows/macos.yml: Remove OMP_ROOT environment variable to verify correctness - CMakeLists.txt: Remove old check for APPLE in main CMakeLists.txt
|
It seems that automation of build/ is good but failed on actual linkage, maybe we didn't actually define an include path that is based on OpenMP_ROOT inside of CMakeLists.txt, do you want me to add that directly to CXXFlags just as the yml is doing? |
|
hmm i see the problem now, I don't think the CMakeLists.txt in tests/ gets any information about the OpenMP_ROOT variable in CMakeLists.txt in runtime/ |
|
This should run fine now on github actions, I just want to make sure there's a way to actually use another variables like OPENMP_MACOS_INCLUDE_DIR instead of coupling the thing into CMakeLists.txt just like the yml. I've refactored the appending of CMAKE_CXX_FLAGS into different target_include_dir of different targets in tests/ now. I'd love some feedbacks @fodinabor |
|
@fodinabor Do you still have some concerns? |
|
No worries! I'm just happy every build passes now :) |
This helps create an easier and more robust build for beginners, fixes #1355