Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add half int constructor #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Mar 3, 2023
Merged

Add half int constructor #957

merged 50 commits into from
Mar 3, 2023

Conversation

normallytangent
Copy link
Collaborator

Fixes #956

normallytangent and others added 30 commits November 29, 2022 18:14
@normallytangent
add OpenMP path for macos build
386c89e
@normallytangent
add path to openmp_c_incl_dir
ab66c3d
@normallytangent
look for libomp version
6b37832
@normallytangent
add c flags and openmp lib name
f867cd8
@normallytangent
fix typo in cmake var
594b8f1
@normallytangent
add path to omp library
8396229
@normallytangent
add libomp path for CXX
b6883ee
@normallytangent
fix libomp lib path
24c9982
@normallytangent
add libomp path for building tests
27cc88c
@normallytangent
remove hipsycl targe and other cmake variables for libomp
ae2e77d
@normallytangent
test installation
c39af3f
@normallytangent
add var for accelerated cpu backend
4daf1a7
@normallytangent
fix typo in macos ci
d5125d8
@normallytangent
remove accelerated cpu backend
bd37393
@normallytangent
Merge branch 'illuhad:develop' into develop
f7a4775
@normallytangent
provide absolute path to bin
be90d55
@normallytangent
library-only with apple clang
cb81cb5
@normallytangent
remove self test of hipSYCL build
417643b
@normallytangent
fix cpu test: add path to libomp
245dacf
@normallytangent
change version of libomp
6c6064a
@normallytangent
add libomp paths for test
a4efb5a
@normallytangent
debug omp_root
d964b34
@normallytangent
debug build tests omp
2699bf3
@normallytangent
remove omp.library-only from apple clang version
d7a9242
@normallytangent
add all libomp cmake flags
9e1250b
@normallytangent
fix typo
a2c594a
@normallytangent
set omp_root env var
78f144c
@normallytangent
add OMP_CXX_FLAGS to build
bfbbc80
@normallytangent
add OMP_CXX_FLAGS to build tests
43de90d
@normallytangent
add cmake_cxx_flags for building tests
9c409b9
normallytangent and others added 18 commits December 7, 2022 11:27
@normallytangent
clean-up: remove flags that are not needed
62741b7
@normallytangent
fix flag name from OpenMP_ to OMP_
7bd6e10
@normallytangent
add both OpenMP and OMP flags
59962bd
@normallytangent
add cmake variable for openmp
4009bf4
@normallytangent
add paths to libomp
4b5cbb5
@normallytangent
debug
ed9ee7d
@normallytangent
debug boost
a988966
@normallytangent
debug tests: add cmake_cxx_flags because setting omp_cxx_flags in bui…
3acacdf 
…ld removes boost
@normallytangent
fix ld flags in cmake_cxx in tests
2d7da17
@normallytangent
remove OMP_CXX_FLAGS
249020f
@normallytangent @fodinabor
Reduce hipsycl build cmake options .github/workflows/macos.yml
10e3a3d 
Co-authored-by: fodinabor <[email protected]>
@normallytangent @fodinabor
Update build tests options .github/workflows/macos.yml
fafd172 
Co-authored-by: fodinabor <[email protected]>
@normallytangent
Merge branch 'illuhad:develop' into develop
32e9e2c
@normallytangent
Merge branch 'illuhad:develop' into develop
5c8f3ef
@normallytangent
Merge branch 'OpenSYCL:develop' into develop
04a1f1c
@normallytangent
Merge branch 'OpenSYCL:develop' into develop
9fa589c
@normallytangent
Merge branch 'OpenSYCL:develop' into develop
3abaedd
@normallytangent
add matching constructor for int
45dce38
@normallytangent normallytangent requested a review from illuhad March 1, 2023 12:01
illuhad
illuhad approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@illuhad illuhad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! For the issue around the explicit constructors, you can either address this in this PR or in a subsequent PR - whatever you prefer :)

@illuhad illuhad merged commit b2e3f33 into AdaptiveCpp:develop Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illuhad illuhad illuhad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ambiguous type conversion in sycl::half
2 participants
@normallytangent @illuhad