Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Windows GitHub CI #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Apr 27, 2023
Merged

Fix Windows GitHub CI #977

merged 35 commits into from
Apr 27, 2023

Conversation

nilsfriess
Copy link
Collaborator

@nilsfriess nilsfriess commented Mar 15, 2023 •
edited
Loading

This PR fixes the Windows CI.
There are still a few TODOs (but at least the CPU tests compile):

  • I've commented out this because the function setDeviceMangleContext does not exist in LLVM 15 (I think it was removed in LLVM13). Maybe @fodinabor knows if it is fine to just remove this?
  • Compilation of tests with CUDA
  • Add more CUDA versions
  • CPU tests are compiled but not executed
  • Upload prebuilt LLVM on Uni servers, not Dropbox

Edit: Just compiling and running the tests for CPU for now

nilsfriess added 21 commits March 15, 2023 10:51
@nilsfriess
Rewrite github action file for windows
5ef2032 
- Use windows-2019 image
- Use prebuilt LLVM 15
- Build boost in CI
@nilsfriess
Add full path to clang
3d8cedd 
In the Github runner, another LLVM is installed in C:\Program Files,
we want to use the prebuilt one
@nilsfriess
Remove continue-on-error
ad1da52
@nilsfriess
Prepend path to prebuilt LLVM to PATH
2f9475d
@nilsfriess
Comment out code that does not compile with LLVM13+
68d4047 
TODO: Check if this is still necessary and how to make it work with
LLVM13+
@nilsfriess
Link against LLVMSupport on Windows
d84196a 
Required for symbols from LLVM CommandLine library
@nilsfriess
Build in Release mode to match build type of LLVM
a4b915f
@nilsfriess
Add step to build CPU tests
84875fa
@nilsfriess
Add missing cd command
90fc174
@nilsfriess
Use correct path to hipsycl-config.cmake
94e3196
@nilsfriess
Add missing quotes
85a65f9
@nilsfriess
Run CPU tests
1bae9db
@nilsfriess
Fix path
8187d9e
@nilsfriess
Fix typo
30c4477
@nilsfriess
Use cmd instead of powershell
a675af7
@nilsfriess
Add path to install_dir/bin to PATH to make dlls findable
3f84f72
@nilsfriess
Add missing backslash
6922ab0
@nilsfriess
Add steps to install CUDA
6a32093
@nilsfriess
Fix typo in CUDA version
2f70fdb
@nilsfriess
Add step to build tests with CUDA backend
715a636
@nilsfriess
Build CUDA tests in own directory
e8dde84
@fodinabor
Copy link
Collaborator

Re the setDeviceMangleContext, I am unsure, if needed. Will try to test with a GPU soon-ish..
But I assume, it will only be necessary for LLVM < 13, since the other macro paths do create the mangle context in place anyways?

@nilsfriess nilsfriess force-pushed the fix-windows-github-ci branch from ef76c48 to 35e6582 Compare March 21, 2023 14:23
@nilsfriess
Add missing quotes
32d2f01
@nilsfriess
Remove step to build CUDA tests
2c4f9bf 
The prebuilt LLVM was not build with CUDA enabled
@nilsfriess
Add steps to build with prebuilt clang 11
134e649
@nilsfriess
Enable calling setDeviceMangleContext for LLVM 11 and 12
ed4736d 
In fact, this is not available in LLVM 11 (only when patched with
https://reviews.llvm.org/D69322) but the prebuilt LLVM in CI is
exactly a patched LLVM 11.
@nilsfriess
Remove clang11 from tested clang versions
45b2392
@nilsfriess nilsfriess marked this pull request as ready for review March 23, 2023 13:57
@illuhad
Copy link
Collaborator

illuhad commented Mar 27, 2023

Maybe @fodinabor can have a look at this?

@fodinabor fodinabor self-requested a review March 27, 2023 14:22
@illuhad
Copy link
Collaborator

illuhad commented Apr 26, 2023

@fodinabor are you still planning to look at this? If not it's fine, I'd just like to merge this soonish as it should be a massive quality of life improvement once contributors are no longer spammed with emails about Windows CI failures :-)

@fodinabor
Copy link
Collaborator

Sorry for the delay...
So it seems that with an LLVM 15 version that does have the NVPTX backend included (not the case for the binary version used in the CI), we can build the tests successfully, and some tests even pass (device_compilation_tests e.g.) but running sycl_tests still has some issues... so far most issues I found seem to be related to type ABI mismatches on CPU and GPU: long on MS ABI is 4 byte, but 8 byte on GPU.
But not sure if that's the only issue.
That being said, I haven't seen any indication so far that there might be mangling issues, so I guess go ahead with merging this?

@illuhad
Copy link
Collaborator

illuhad commented Apr 27, 2023

Thanks for the feedback!

so far most issues I found seem to be related to type ABI mismatches on CPU and GPU: long on MS ABI is 4 byte, but 8 byte on GPU.

yikes... That means that basic code has the chance of blowing up, not even talking about data structures.. even buffer<long> is not going to work. We should really consider focusing on MinGW..
(SSCP also solves this issue :- ) )

@illuhad illuhad merged commit d382698 into AdaptiveCpp:develop Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illuhad illuhad illuhad approved these changes

@fodinabor fodinabor Awaiting requested review from fodinabor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilsfriess @fodinabor @illuhad