implementing DBS(Depth Below Surface)#138
Conversation
| @@ -1,5 +1,6 @@ | |||
| use core::str; | |||
|
|
|||
| use dbs::DbsData; | |||
There was a problem hiding this comment.
- You need to export the DbsData in
sentences/mod.rslike the rest of the *Data structs and you can remove this import assentences::*is imported below.
| /// ```text | ||
| /// 1 2 3 4 5 6 7 | ||
| /// | | | | | | | | ||
| /// $--DBT,x.x,f,x.x,M,x.x,F*hh<CR><LF> |
There was a problem hiding this comment.
| /// $--DBT,x.x,f,x.x,M,x.x,F*hh<CR><LF> | |
| /// $--DBT,x.x,f,x.x,M,x.x,F*hh<CR><LF> | |
| /// ``` |
There was a problem hiding this comment.
Whopsy, I see a different sentence example here?! DBT instead of DBS
| /// In real-world sensors, sometimes not all three conversions are reported. So you might see something like $SDDBT,,f,22.5,M,,F*cs | ||
| /// Example: $DBS,x.x,f,x.x,M,x.x,F*hh<CR><LF> | ||
| /// ``` |
There was a problem hiding this comment.
| /// In real-world sensors, sometimes not all three conversions are reported. So you might see something like $SDDBT,,f,22.5,M,,F*cs | |
| /// Example: $DBS,x.x,f,x.x,M,x.x,F*hh<CR><LF> | |
| /// ``` | |
| /// | |
| /// In real-world sensors, sometimes not all three conversions are reported. | |
| /// So you might see something like `$SDDBT,,f,22.5,M,,F*cs` | |
| /// | |
| /// Examples: | |
| /// * `$DBS,x.x,f,x.x,M,x.x,F*hh<CR><LF>` |
elpiel
left a comment
There was a problem hiding this comment.
Great first PR @asnimansari 🎉 and thank you for your contribution!
A few small tweaks on the docs and exported Data struct and it should be good for merging.
|
@elpiel made the suggested changes. |
|
CI checks are failing, you can check them out and fix them |
|
|
You gave me an idea 💡 I'll see hooks and how we can set them up. Something, though, you need to run clippy and rustfmt with nightly but build your code using stable rust. Imo This is out of scope for this pr |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 78.80% 78.62% -0.19%
==========================================
Files 38 39 +1
Lines 1425 1450 +25
==========================================
+ Hits 1123 1140 +17
- Misses 302 310 +8 ☔ View full report in Codecov by Sentry. |
|
@elpiel could you help me with the remaining checks? |
|
It's ready to be merged. |
@elpiel done. |
|
cool |
|
Thank you once again for opening the pr! I approved the run and just had to wait for it to finish 😋 |
|
Cool. Thanks. |
No description provided.