Added parsing BWW messages#86
Merged
Merged
Conversation
elpiel
requested changes
Apr 17, 2023
Member
elpiel
left a comment
There was a problem hiding this comment.
All looks good to me, only 2 small requested changes.
Thank you once again for your PR!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 79.60% 80.22% +0.61%
==========================================
Files 30 31 +1
Lines 1123 1153 +30
==========================================
+ Hits 894 925 +31
+ Misses 229 228 -1
☔ View full report in Codecov by Sentry. |
elpiel
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added parsing BWW messages (#54), based on https://gpsd.gitlab.io/gpsd/NMEA.html#_bww_bearing_waypoint_to_waypoint