Exporting some enums#89
Merged
Merged
Conversation
Member
|
Hmmm... I would instead leave them in their respective module making them public and keep the same names. If someone wants to rename the import they can do it. Long names are never something I personally prefer. We can do breaking changes, it's not a big deal, especially bumping minor versions. And Thank you for the PR! |
Author
|
Changed to make all modules under |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 80.35% 80.31% -0.04%
==========================================
Files 33 33
Lines 1196 1199 +3
==========================================
+ Hits 961 963 +2
- Misses 235 236 +1
☔ View full report in Codecov by Sentry. |
elpiel
approved these changes
May 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I Added below enums exporting.
RmcNavigationStatusGsaMode1GsaMode2PgrmzFixTypeI think it would be better to rename
NavigationStatustoGnsNavigationStatusto clarify the difference fromRmcNavigationStatus. However, this would be a destructive change, so I would like your opinion.I think it would be better to export the names of both
NavigationStatusandGnsNavigationStatus, but encourageNavigationStatusto use#[deprecated]to useGnsNavigationStatus.