Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added dark mode support #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Conversation

kyledold
Copy link
Contributor

I moved the colors to the assets and made them invert for dark mode so it looks more like what GitHub does when it's in dark mode.

@AnderGoig
Copy link
Owner

Thanks @kyledold! Really like the idea of moving the colors to the Assets 👍

The only problem I see by inverting the colors is that it could be a bit confusing. In dark mode it actually looks like you made more contributions in the days that you made less, don't you think so?

@kyledold
Copy link
Contributor Author

kyledold commented Feb 6, 2021

Hey,
Hmmm...maybe I need to tweak the colors slightly for when its a level 4 color.

What I was trying to do was match what Github was doing in their dark vs light mode (like below).
github_darkgithub_light

Also this has recently stopped working for me, are you aware of any changes to that Github have made recently that would break this widget?

@AnderGoig
Copy link
Owner

Yeah, maybe we can try with darker colors for less contributions and brighter (but not pale) for more contributions.

Also this has recently stopped working for me, are you aware of any changes to that Github have made recently that would break this widget?

Yes, they changed some stuff which made the HTML parsing fail, I've fixed that in 1.0.3 but it's not live yet, still pending approval.

@kyledold
Copy link
Contributor Author

kyledold commented Feb 6, 2021

Agreed, I'll try tweaking the colors after 1.0.3 is merged :)

@kyledold
Copy link
Contributor Author

kyledold commented Feb 8, 2021

@AnderGoig I've made some changes to the colors (for dark mode only) so hopefully it looks a bit clearer now which days there were more contributions.

Simulator Screen Shot - iPhone 12 mini - 2021-02-08 at 12 12 38Simulator Screen Shot - iPhone 12 mini - 2021-02-08 at 12 12 54

@AnderGoig
Copy link
Owner

Yeah, much better now in my opinion! Thanks for your contribution 🙂

@AnderGoig AnderGoig merged commit 1aba7f0 into AnderGoig:develop Feb 8, 2021
@kyledold kyledold deleted the dark-mode-support branch February 8, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants