Fix cross dlg pollution #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrates add_msg pollution bug across dialogs
Setup: Create two dialogs, 'dlg_a' and 'dlg_b'
In 'dlg_a', run this code in the same message:
Bug:
msg2 doesn't get created anywhere because
__msg_idin 'dlg_a' scope was set by the firstadd_msgcall with a message id fromdlg_b.Impact: Any function that calls
add_msgwith differentdnamevalues pollutes the caller's__msg_id, breaking subsequent message placement. If the add_msg calls happen in different messages, __msg_id is reset to the message id and the issue won't happen.Possible fix: add_msg should call set_var('__msg_id', ...) only if dname parameter is not set.
Workaround: Always pass explicit
idandplacementparameters when calling severaladd_msgafter cross-dialog operations in one message.