Codestin Search App

robfrank · 2025-09-04T18:32:40Z

This pull request introduces improvements to variable handling in the SQL execution context and enhances test coverage for batch scripts and variable access. The most significant changes are the addition of support for accessing fields of result set variables using dot notation, refactoring for clarity and consistency, and new tests to validate these features.

Variable access and handling improvements

Enhanced the getVariable method in BasicCommandContext to support dot notation (e.g., $row.a), allowing direct access to fields within result set variables. This improves usability in SQL scripts and batch operations.
Updated method signatures in the CommandContext interface for improved clarity and consistency (e.g., renaming parameters for better readability).

Test coverage and validation

Added a new test testForeachResultSetReadFieldName in BatchTest.java to verify that field access via dot notation works correctly in SQL scripts.
Refactored multi-line script strings in BatchScriptTest.java to use Java's text block syntax for better readability and maintainability.

Code quality

Cleaned up imports in BasicCommandContext.java for clarity and reduced unnecessary wildcard usage.

gemini-code-assist

Summary of Changes

Hello @robfrank, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves how variables are handled within SQL execution contexts, particularly by introducing support for accessing fields of result set variables using dot notation. These changes aim to enhance the usability and clarity of SQL scripts, backed by expanded test coverage to ensure the new functionalities work as expected.

Highlights

Enhanced Variable Access: The getVariable method in BasicCommandContext now supports dot notation (e.g., $row.a) for direct access to fields within result set variables, improving SQL script usability.
Code Clarity and Consistency: Method signatures in the CommandContext interface have been updated for better readability and consistency, including parameter renaming.
Improved Test Coverage: A new test, testForeachResultSetReadFieldName, was added to BatchTest.java to validate the new field access via dot notation in SQL scripts.
Code Readability: Multi-line script strings in BatchScriptTest.java were refactored to use Java's text block syntax, enhancing maintainability.
Import Clean-up: Imports in BasicCommandContext.java were cleaned up, replacing wildcard imports with specific class imports.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a valuable enhancement for handling variables in SQL scripts by allowing dot notation for field access on result set variables. The associated code quality improvements, such as using text blocks for multi-line strings and cleaning up imports, are also positive changes that improve maintainability. However, I've identified a critical issue in the implementation of the dot notation handling within BasicCommandContext.java. The current logic can cause an ArrayIndexOutOfBoundsException or lead to silent incorrect evaluation for certain variable name patterns. I have provided a detailed comment and a code suggestion to address this vulnerability.

codacy-production · 2025-09-05T10:30:41Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `cd2d275`¹	✅ 83.10%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`cd2d275`)	Report Missing	Report Missing	Report Missing
Head commit (`261d1bb`)	71011	45655	64.29%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#2467)	71	59	83.10%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

…ution

…anning

(cherry picked from commit 414ca1c)

Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.3 to 7.0.0. Release notes *Sourced from [actions/checkout's releases](https://github.com/actions/checkout/releases).* > v7.0.0 > ------ > > What's Changed > -------------- > > * block checking out fork pr for pull\_request\_target and workflow\_run by [`@aiqiaoy`](https://github.com/aiqiaoy) in [actions/checkout#2454](https://redirect.github.com/actions/checkout/pull/2454) > * Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 in the minor-actions-dependencies group across 1 directory by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/checkout#2458](https://redirect.github.com/actions/checkout/pull/2458) > * Bump flatted from 3.3.1 to 3.4.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/checkout#2460](https://redirect.github.com/actions/checkout/pull/2460) > * Bump js-yaml from 4.1.0 to 4.2.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/checkout#2461](https://redirect.github.com/actions/checkout/pull/2461) > * Bump `@actions/core` and `@actions/tool-cache` and Remove uuid by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/checkout#2459](https://redirect.github.com/actions/checkout/pull/2459) > * upgrade module to esm and update dependencies by [`@aiqiaoy`](https://github.com/aiqiaoy) in [actions/checkout#2463](https://redirect.github.com/actions/checkout/pull/2463) > * Bump the minor-npm-dependencies group across 1 directory with 3 updates by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/checkout#2462](https://redirect.github.com/actions/checkout/pull/2462) > * getting ready for checkout v7 release by [`@aiqiaoy`](https://github.com/aiqiaoy) in [actions/checkout#2464](https://redirect.github.com/actions/checkout/pull/2464) > * update error wording by [`@aiqiaoy`](https://github.com/aiqiaoy) in [actions/checkout#2467](https://redirect.github.com/actions/checkout/pull/2467) > > New Contributors > ---------------- > > * [`@aiqiaoy`](https://github.com/aiqiaoy) made their first contribution in [actions/checkout#2454](https://redirect.github.com/actions/checkout/pull/2454) > > **Full Changelog**: <actions/checkout@v6.0.3...v7.0.0> Changelog *Sourced from [actions/checkout's changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md).* > Changelog > ========= > > v7.0.0 > ------ > > * Block checking out fork PR for pull\_request\_target and workflow\_run by [`@aiqiaoy`](https://github.com/aiqiaoy) in [actions/checkout#2454](https://redirect.github.com/actions/checkout/pull/2454) > * Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 in the minor-actions-dependencies group across 1 directory by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/checkout#2458](https://redirect.github.com/actions/checkout/pull/2458) > * Bump flatted from 3.3.1 to 3.4.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/checkout#2460](https://redirect.github.com/actions/checkout/pull/2460) > * Bump js-yaml from 4.1.0 to 4.2.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/checkout#2461](https://redirect.github.com/actions/checkout/pull/2461) > * Bump `@actions/core` and `@actions/tool-cache` and Remove uuid by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/checkout#2459](https://redirect.github.com/actions/checkout/pull/2459) > * upgrade module to esm and update dependencies by [`@aiqiaoy`](https://github.com/aiqiaoy) in [actions/checkout#2463](https://redirect.github.com/actions/checkout/pull/2463) > * Bump the minor-npm-dependencies group across 1 directory with 3 updates by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/checkout#2462](https://redirect.github.com/actions/checkout/pull/2462) > > v6.0.3 > ------ > > * Fix checkout init for SHA-256 repositories by [`@yaananth`](https://github.com/yaananth) in [actions/checkout#2439](https://redirect.github.com/actions/checkout/pull/2439) > * fix: expand merge commit SHA regex and add SHA-256 test cases by [`@yaananth`](https://github.com/yaananth) in [actions/checkout#2414](https://redirect.github.com/actions/checkout/pull/2414) > > v6.0.2 > ------ > > * Fix tag handling: preserve annotations and explicit fetch-tags by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2356](https://redirect.github.com/actions/checkout/pull/2356) > > v6.0.1 > ------ > > * Add worktree support for persist-credentials includeIf by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2327](https://redirect.github.com/actions/checkout/pull/2327) > > v6.0.0 > ------ > > * Persist creds to a separate file by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2286](https://redirect.github.com/actions/checkout/pull/2286) > * Update README to include Node.js 24 support details and requirements by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2248](https://redirect.github.com/actions/checkout/pull/2248) > > v5.0.1 > ------ > > * Port v6 cleanup to v5 by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2301](https://redirect.github.com/actions/checkout/pull/2301) > > v5.0.0 > ------ > > * Update actions checkout to use node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2226](https://redirect.github.com/actions/checkout/pull/2226) > > v4.3.1 > ------ > > * Port v6 cleanup to v4 by [`@ericsciple`](https://github.com/ericsciple) in [actions/checkout#2305](https://redirect.github.com/actions/checkout/pull/2305) > > v4.3.0 > ------ > > * docs: update README.md by [`@motss`](https://github.com/motss) in [actions/checkout#1971](https://redirect.github.com/actions/checkout/pull/1971) > * Add internal repos for checking out multiple repositories by [`@mouismail`](https://github.com/mouismail) in [actions/checkout#1977](https://redirect.github.com/actions/checkout/pull/1977) > * Documentation update - add recommended permissions to Readme by [`@benwells`](https://github.com/benwells) in [actions/checkout#2043](https://redirect.github.com/actions/checkout/pull/2043) > * Adjust positioning of user email note and permissions heading by [`@joshmgross`](https://github.com/joshmgross) in [actions/checkout#2044](https://redirect.github.com/actions/checkout/pull/2044) > * Update README.md by [`@nebuk89`](https://github.com/nebuk89) in [actions/checkout#2194](https://redirect.github.com/actions/checkout/pull/2194) > * Update CODEOWNERS for actions by [`@TingluoHuang`](https://github.com/TingluoHuang) in [actions/checkout#2224](https://redirect.github.com/actions/checkout/pull/2224) > * Update package dependencies by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/checkout#2236](https://redirect.github.com/actions/checkout/pull/2236) > > v4.2.2 > ------ > > * `url-helper.ts` now leverages well-known environment variables by [`@jww3`](https://github.com/jww3) in [actions/checkout#1941](https://redirect.github.com/actions/checkout/pull/1941) > * Expand unit test coverage for `isGhes` by [`@jww3`](https://github.com/jww3) in [actions/checkout#1946](https://redirect.github.com/actions/checkout/pull/1946) > > v4.2.1 > ------ > > * Check out other refs/\* by commit if provided, fall back to ref by [`@orhantoy`](https://github.com/orhantoy) in [actions/checkout#1924](https://redirect.github.com/actions/checkout/pull/1924) ... (truncated) Commits * [`9c091bb`](actions/checkout@9c091bb) update error wording ([#2467](https://redirect.github.com/actions/checkout/issues/2467)) * [`1044a6d`](actions/checkout@1044a6d) getting ready for checkout v7 release ([#2464](https://redirect.github.com/actions/checkout/issues/2464)) * [`f028218`](actions/checkout@f028218) Bump the minor-npm-dependencies group across 1 directory with 3 updates ([#2462](https://redirect.github.com/actions/checkout/issues/2462)) * [`d914b26`](actions/checkout@d914b26) upgrade module to esm and update dependencies ([#2463](https://redirect.github.com/actions/checkout/issues/2463)) * [`537c7ef`](actions/checkout@537c7ef) Bump `@actions/core` and `@actions/tool-cache` and Remove uuid ([#2459](https://redirect.github.com/actions/checkout/issues/2459)) * [`130a169`](actions/checkout@130a169) Bump js-yaml from 4.1.0 to 4.2.0 ([#2461](https://redirect.github.com/actions/checkout/issues/2461)) * [`7d09575`](actions/checkout@7d09575) Bump flatted from 3.3.1 to 3.4.2 ([#2460](https://redirect.github.com/actions/checkout/issues/2460)) * [`0f9f3aa`](actions/checkout@0f9f3aa) Bump actions/publish-immutable-action ([#2458](https://redirect.github.com/actions/checkout/issues/2458)) * [`f9e715a`](actions/checkout@f9e715a) block checking out fork pr for pull\_request\_target and workflow\_run ([#2454](https://redirect.github.com/actions/checkout/issues/2454)) * See full diff in [compare view](actions/checkout@df4cb1c...9c091bb) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/checkout&package-manager=github\_actions&previous-version=6.0.3&new-version=7.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

robfrank added this to the 25.9.1 milestone Sep 4, 2025

robfrank self-assigned this Sep 4, 2025

robfrank added enhancement New feature or request do not merge The PR is not ready high_priority labels Sep 4, 2025

gemini-code-assist Bot reviewed Sep 4, 2025

View reviewed changes

Comment thread engine/src/main/java/com/arcadedb/query/sql/executor/BasicCommandContext.java

robfrank linked an issue Sep 4, 2025 that may be closed by this pull request

Feature Request: SQLSCRIPT - Dynamic Type Naming #2230

Closed

robfrank changed the title ~~#2230 initial work on enhanced variable behaviour in SQL script~~ #2230 enhance variable behaviour in SQL script Sep 5, 2025

robfrank force-pushed the feat/2230-dynamic-naming-sqlscript branch 2 times, most recently from 99ec709 to 4c2b164 Compare September 9, 2025 07:24

robfrank added wip and removed do not merge The PR is not ready labels Sep 9, 2025

robfrank modified the milestones: 25.9.1, 25.8.1 Sep 10, 2025

lvca self-requested a review September 10, 2025 06:33

robfrank added 11 commits September 10, 2025 08:34

#2230 initial work on enhanced variable behaviour in SQL script

c5247f5

#2230 enhance variable handling in SQL script execution

c78a618

#2230 enhance dynamic naming in SQL script execution

17fbbab

fix: handle nested property access in SQL command context

d1fab6e

feat: enhance dynamic variable handling in SQL script execution

92ffb79

feat: update dynamic naming for SQL script types in BatchTest

8b9abd8

feat: implement dynamic variable handling for SQL script types

439cc27

feat: enhance dynamic naming and variable handling in SQL script exec…

e943a66

…ution

feat: enhance dynamic naming and variable handling in SQL script exec…

a4fd392

…ution

feat: improve null safety in targetType handling for SQL execution pl…

49a3d24

…anning

feat: add dynamic SQL script for schema creation and property indexing

261d1bb

lvca approved these changes Sep 10, 2025

View reviewed changes

robfrank force-pushed the feat/2230-dynamic-naming-sqlscript branch from 4c2b164 to 261d1bb Compare September 10, 2025 06:37

robfrank merged commit 414ca1c into main Sep 10, 2025
5 of 7 checks passed

robfrank deleted the feat/2230-dynamic-naming-sqlscript branch September 10, 2025 06:37

robfrank added a commit that referenced this pull request Sep 10, 2025

#2230 enhance variable handling in SQL script (#2467) [skip ci[

f81e54c

(cherry picked from commit 414ca1c)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

#2230 enhance variable behaviour in SQL script#2467

#2230 enhance variable behaviour in SQL script#2467
robfrank merged 11 commits into
mainfrom
feat/2230-dynamic-naming-sqlscript

robfrank commented Sep 4, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

codacy-production Bot commented Sep 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

robfrank commented Sep 4, 2025

Variable access and handling improvements

Test coverage and validation

Code quality

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

codacy-production Bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codacy-production Bot commented Sep 5, 2025 •

edited

Loading