Clarify Brake mode position requirement and remove misleading auto-disarm statement#7691
Open
jinmussj wants to merge 1 commit intoArduPilot:masterfrom
Open
Clarify Brake mode position requirement and remove misleading auto-disarm statement#7691jinmussj wants to merge 1 commit intoArduPilot:masterfrom
jinmussj wants to merge 1 commit intoArduPilot:masterfrom
Conversation
Contributor
|
Please squash to a single commit |
d247e5f to
c899804
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was discussed in issue #31877.
1.Clarify Brake mode requires a usable position estimate, not strictly GPS
Update the Brake mode page to say the mode requires a usable position estimate rather than GPS specifically, matching behavior when non-GPS positioning remains available.
2.Remove misleading Brake mode auto-disarm statement
Remove the “immediately disarm” sentence from the Brake mode page for clarity, as discussed in issue #31877. The current wording can be misleading because the observed behavior follows general landing/disarm logic rather than a Brake-specific rule.
Also, in the default configuration, auto-disarm timing is not necessarily immediate and may instead follow the DISARM_DELAY setting (default: 10 seconds). More generally, whether and when auto-disarm occurs can vary with disarm-related settings such as PILOT_THR_BHV and DISARM_DELAY.