Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix vendor_bundle? behavior in CppLibrary (no longer hard-code bundle location) #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

Fix vendor_bundle? behavior in CppLibrary (no longer hard-code bundle location) #98

merged 1 commit into from
Jan 28, 2019

Conversation

ianfixes
Copy link
Collaborator

It is what it says

@ianfixes
Copy link
Collaborator Author

@hlovdal can you try specifying this branch in your Gemfile to see if it fixes #69 ?

source 'https://rubygems.org'
gem 'arduino_ci', :git => 'https://github.com/ianfixes/arduino_ci.git', :branch => '2019-01-27_vendor_bundle'

@ianfixes ianfixes force-pushed the 2019-01-27_vendor_bundle branch from d287c26 to ca55306 Compare January 28, 2019 04:25
@ianfixes ianfixes added bug Something isn't working rubygem Ruby code is affected labels Jan 28, 2019
@ianfixes ianfixes mentioned this pull request Jan 28, 2019
Merged
@ianfixes ianfixes changed the title Fix CppLibrary::vendor_bundle? to use bundle show paths intead of assuming vendor/bundle Fix vendor_bundle? behavior in CppLibrary (no longer hard-code bundle location) Jan 28, 2019
@ianfixes ianfixes force-pushed the 2019-01-27_vendor_bundle branch 3 times, most recently from 7aa7d04 to 21c1266 Compare January 28, 2019 14:33
@ianfixes ianfixes force-pushed the 2019-01-27_vendor_bundle branch from 21c1266 to c0f3f42 Compare January 28, 2019 15:50
@ianfixes ianfixes mentioned this pull request Jan 28, 2019
Closed
@ianfixes ianfixes merged commit 90b3e68 into master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working rubygem Ruby code is affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ianfixes