[fix] Fix simple storage unit tests on IPv6 nodes#135
Merged
Conversation
Signed-off-by: 0oshowero0 <[email protected]>
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes IPv6-only test hangs in tests/test_simple_storage_unit.py by ensuring the mock storage client creates its ZMQ DEALER socket via the shared create_zmq_socket() helper and receives the storage node’s IP so IPv6 socket options are enabled consistently with production.
Changes:
- Updated
MockStorageClientto create its ZMQ socket viacreate_zmq_socket(ctx, zmq.DEALER, storage_ip)(enablingzmq.IPV6when appropriate). - Extended the
storage_setupfixture to also yieldzmq_info.ip. - Updated all test call sites to pass
storage_ipintoMockStorageClient.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the simple storage unit test mock client to create its ZMQ DEALER socket through the shared
create_zmq_socket()helper instead of constructing a raw socket directly.The fixture now passes the storage node IP from
ZMQServerInfointo the mock client, allowing IPv6 endpoints to correctly enable the zmq.IPV6 socket option. This matches production socket setup behavior and fixes hangs/failures when running tests/test_simple_storage_unit.py on IPv6-only environments.