fix: simplify && and || when the LHS is constant #2947
Merged
+82
−239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff06740 to
67c8361
Compare
We now precompute the LHS and have an additional optimization to check the truthiness of the LHS and use that to simplify the expression to either the LHS or the RHS, without generating an `if`. Fixes AssemblyScript#2946.
67c8361 to
fd9c479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2946.
Changes proposed in this pull request:
⯈ Precompute the LHSes of
&&and||when possible⯈ Simplify the emitted expression for
&&and||if LHS is a constant value