Feature: Add Option to Strip Authorization Header on Redirect #2090
+153
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation header on redirects
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new configuration option, isStripAuthorizationOnRedirect(), to control whether the Authorization header is stripped during HTTP redirects. Key changes include new tests to verify default and custom behavior, modifications to the client configuration and builder to include the new option, and updates in the redirect interceptor to apply the header-stripping behavior.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/test/java/org/asynchttpclient/StripAuthorizationOnRedirectHttpTest.java | Adds tests to validate header propagation and stripping on redirects. |
| client/src/test/java/org/asynchttpclient/DefaultAsyncHttpClientConfigTest.java | Provides unit test coverage for the new configuration option with default and explicit settings. |
| client/src/main/java/org/asynchttpclient/netty/handler/intercept/Redirect30xInterceptor.java | Updates the redirect interceptor to remove the Authorization header based on the new config flag. |
| client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java | Introduces a new field and builder method to manage the stripAuthorizationOnRedirect setting. |
| client/src/main/java/org/asynchttpclient/AsyncHttpClientConfig.java | Extends the client config interface with the new method. |
client/src/main/java/org/asynchttpclient/netty/handler/intercept/Redirect30xInterceptor.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java
Outdated
Show resolved
Hide resolved
…pt/Redirect30xInterceptor.java Co-authored-by: Copilot <[email protected]>
…tConfig.java Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1884