Codestin Search App

heavyweight · 2026-02-20T17:42:51Z

Fixes DOTCOM-16099

Proposed changes:

Ensure same instance of Yjs

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Sync the PR changes to your site
Sync the latest version of gutenberg
Apply this to gutenberg-rtc.ts

import { addFilter } from '@wordpress/hooks';
import { Y } from '@wordpress/sync';

const win = window as unknown as { wp?: { sync?: { Y?: unknown } } };
if ( win.wp?.sync?.Y ) {
	// eslint-disable-next-line no-console
	console.assert( Y === win.wp.sync.Y, 'ERROR: Two Yjs instances detected!' );
	// eslint-disable-next-line no-console
	console.log( 'Yjs instance check passed:', Y === win.wp.sync.Y );
} else {
	// eslint-disable-next-line no-console
	console.error( 'Yjs instance not found!' );
}

// Register PingHub provider and disable Http polling by returning only this provider.
( function register() {
	if ( typeof window === 'undefined' ) {
		return;
	}
	addFilter( 'sync.providers', 'wpcom/pinghub-provider', () => [] );
} )();

The instance check should pass

Changelog

Generate changelog entries for this PR (using AI).

github-actions · 2026-02-20T17:43:47Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the DOTCOM-16099 branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack DOTCOM-16099

bin/jetpack-downloader test jetpack-mu-wpcom-plugin DOTCOM-16099

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-02-20T17:43:56Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2026-02-20T18:01:26Z

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Copilot

Pull request overview

This PR configures Yjs dependency management to ensure a single instance is used across the application, preventing conflicts with shared document types. The change addresses the known Yjs issue where multiple instances break shared document functionality.

Changes:

Added @wordpress/sync, yjs, lib0, and y-protocols as dependencies
Configured webpack externals to map both @wordpress/sync and yjs to WordPress globals
Converted gutenberg-rtc entry point from .js to .ts

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File	Description
projects/packages/jetpack-mu-wpcom/webpack.config.js	Added webpack externals configuration to resolve `@wordpress/sync` and `yjs` to WordPress globals, updated entry point file extension
projects/packages/jetpack-mu-wpcom/package.json	Added `@wordpress/sync`, `yjs`, `lib0`, and `y-protocols` package dependencies

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

arthur791004

Tested and it works as expected.

arthur791004 · 2026-03-03T06:14:22Z

I'll move this forward 🙂

Copilot

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

manzoorwanijk · 2026-03-03T08:30:01Z

+				// Resolve Yjs to the global `wp.sync.Y` to avoid two separate Yjs
+				// instances, which breaks shared document types. See:
+				// https://github.com/yjs/yjs/issues/438
+				yjs: 'wp.sync.Y',


@anomiex should this go through jetpackWebpackConfig.DependencyExtractionPlugin()?

The @wordpress/sync should already do so. I'd be worried that adding it here might break the addition of wp-sync to the .asset.php file, although assuming this got tested presumably it didn't. I'd still remove it here.

yjs won't be handled by DependencyExtractionPlugin by default. I suppose doing it via DependencyExtractionPlugin would probably be better, although you'd have to make sure to configure the added requestMap entry to call for the "wp-sync" handle rather than something like "yjs" that won't actually be registered with WordPress.

Although, I note that the testing code does import { Y } from '@wordpress/sync'; rather than importing yjs directly, so it shouldn't be needed here (or as a dependency at all) in the first place.

The @wordpress/sync should already do so.

Not the current version of Dependency Extraction plugin because the sync package was recently removed from the bundled packages list. It also means that we will have to think of WP compatibility here where wp.sync won’t be available.

WordPress/gutenberg#74671 was included in @wordpress/dependency-extraction-webpack-plugin v6.40.0, which we updated to in #47300.

WP compatibility will be a concern if wp-sync isn't registered by WordPress 6.9. But in that case the exclusion here is still wrong.

The code for the provider will eventually be moved to widgets.wp.com as calypso app to provide support for WoA and self-hosted JP sites.
We were looking to move fast to provide testing sites for the upcoming feature.

github-actions Bot added [mu wpcom Feature] Gutenberg Rtc [Package] Jetpack mu wpcom WordPress.com Features [Status] In Progress labels Feb 20, 2026

github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 20, 2026

heavyweight force-pushed the DOTCOM-16099 branch from 463b4ac to 1e909ad Compare February 24, 2026 10:04

heavyweight marked this pull request as ready for review February 24, 2026 10:07

Copilot AI review requested due to automatic review settings February 24, 2026 10:07

Copilot started reviewing on behalf of heavyweight February 24, 2026 10:08 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

heavyweight requested a review from arthur791004 February 25, 2026 08:24

arthur791004 previously approved these changes Mar 3, 2026

View reviewed changes

heavyweight added 3 commits March 3, 2026 14:11

Setup yjs dependency

4c97531

Revert base file

5a5ba51

Changelog

5e0223e

Copilot AI review requested due to automatic review settings March 3, 2026 06:11

arthur791004 dismissed their stale review via 5e0223e March 3, 2026 06:11

arthur791004 force-pushed the DOTCOM-16099 branch from 449c688 to 5e0223e Compare March 3, 2026 06:11

Copilot started reviewing on behalf of arthur791004 March 3, 2026 06:12 View session

arthur791004 added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Mar 3, 2026

Copilot AI reviewed Mar 3, 2026

View reviewed changes

arthur791004 merged commit d98fa9c into trunk Mar 3, 2026
141 of 145 checks passed

arthur791004 deleted the DOTCOM-16099 branch March 3, 2026 06:50

github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Mar 3, 2026

manzoorwanijk reviewed Mar 3, 2026

View reviewed changes

Conversation

heavyweight commented Feb 20, 2026 • edited by arthur791004 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Changelog

Uh oh!

github-actions Bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control Bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

arthur791004 left a comment

Choose a reason for hiding this comment

Uh oh!

arthur791004 commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

manzoorwanijk Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

anomiex Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

anomiex Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

manzoorwanijk Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

anomiex Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

heavyweight Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

heavyweight commented Feb 20, 2026 •

edited by arthur791004

Loading

github-actions Bot commented Feb 20, 2026 •

edited

Loading

github-actions Bot commented Feb 20, 2026 •

edited

Loading

jp-launch-control Bot commented Feb 20, 2026 •

edited

Loading

heavyweight Mar 4, 2026 •

edited

Loading