Test for the targeted attribute, not the __default alias
#83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note that this test will fail for WordPress versions >= 6.6 that do not include this commit, which is currently all releases >=6.6. But those releases are not in the test matrix. |
|
Thank you @chriszarate! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduced a change to parsed block bindings. It no longer provides the binding under the
__defaultalias and instead only provides the actual targeted attribute (e.g.,contentfor acore/paragraphblock).To be honest, this is a better result for Block Data API consumers, because they are not exposed to an alias that they would need to resolve themselves. Although, to be clear, this is all very theoretical. It is highly unlikely that any API consumers would inspect the bindings at all, which live in the
metadataattribute. Almost certainly, they are only interested in the actual attribute value (e.g.,content), which is unchanged.