Newsletter: Show guidance when Substack images fail to import#109003
Draft
robertbpugh wants to merge 1 commit intotrunkfrom
Draft
Newsletter: Show guidance when Substack images fail to import#109003robertbpugh wants to merge 1 commit intotrunkfrom
robertbpugh wants to merge 1 commit intotrunkfrom
Conversation
When importing from Substack, images frequently fail because Substack hosts them in protected S3 buckets that deny external access. The importer currently shows unsupported file types and unconverted content, but silently drops images that fail with HTTP errors. Add a FailedImagesMessage component to the conversion summary that explains images were not included in the export and provides numbered steps to manually save and re-upload them, with links to the Media Library and Image block support docs. The component renders when the backend provides a failedImagesCount field in the import data. Until the corresponding backend change ships, this code is safely inert (the field defaults to 0). Co-Authored-By: Claude Opus 4.6 <[email protected]>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of NL-482
Proposed Changes
FailedImagesMessagecomponent to the Substack import conversion summary screenfailedImagesCount > 0in the import data_nfor proper singular/plural handlingpadding-inline-start)Why are these changes being made?
When importing from Substack, ~33% of images fail because Substack hosts them in protected storage that denies external access. The importer already surfaces unsupported file types and unconverted content, but silently drops images that fail with HTTP errors. Users see broken images with no explanation or guidance on how to fix them.
This PR adds actionable guidance so users know why images are missing and exactly how to fix them.
Note: This PR is safely inert until a corresponding backend change ships to populate
failedImagesCountin the API response. Until then, the field defaults to 0 and the component does not render.Testing Instructions
/import/{site}/newsletter/substackfailedImagesCountfrom backend yet)failedImagesCount = 5→ verify message appears with "5 images could not be imported..."failedImagesCount = 1→ verify singular "1 image could not be imported..."failedImagesCount = 0→ verify no message appearsPre-merge Checklist