Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Image Studio: Use __i18n_text_domain__ for all translatable strings#109013

Open
t-wright wants to merge 1 commit intotrunkfrom
image-studio-i18n-text-domain
Open

Image Studio: Use __i18n_text_domain__ for all translatable strings#109013
t-wright wants to merge 1 commit intotrunkfrom
image-studio-i18n-text-domain

Conversation

@t-wright
Copy link
Contributor

@t-wright t-wright commented Mar 3, 2026

Part of FORNO-222

Proposed Changes

  • Replace 16 hardcoded 'big-sky' and 'default' text domains with i18n_text_domain across 5 files in packages/image-studio

Why are these changes being made?

  • After the BigSky feature parity PR (Image Studio: Feature parity with Big Sky #108710) was merged, some translatable strings in Image Studio were still using hardcoded text domains ('big-sky' or 'default') instead of the build-time __i18n_text_domain__ variable. This fixes those.

Testing Instructions

  • Check out this branch and run yarn install
  • Run yarn test-packages --testPathPattern='packages/image-studio' and confirm all tests pass
  • Verify no remaining hardcoded text domains: grep -rn "'big-sky'" packages/image-studio/src/

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Replaces hardcoded 'big-sky' and 'default' text domains so translations
resolve correctly regardless of which app bundles Image Studio.
@t-wright t-wright marked this pull request as ready for review March 3, 2026 00:01
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 3, 2026
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • agents-manager
  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug image-studio-i18n-text-domain on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants