Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Aug 18, 2021

No description provided.

@qiaozha qiaozha changed the title Add test framework for mgmt sdk Add test framework generation for mgmt sdk Aug 18, 2021
@sarangan12
Copy link
Contributor

As discussed offline, I will think if there is any alternative to downloading the test-utils package. Else, I will discuss with releasing it to npmjs to the package owner. Will update this issue soon.

Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to add karma config to run tests against the browser?

@qiaozha
Copy link
Member Author

qiaozha commented Aug 18, 2021

Are we planning to add karma config to run tests against the browser?

Yes, but currently I want to make sure tests against node works

@qiaozha
Copy link
Member Author

qiaozha commented Sep 1, 2021

hold on this PR as the public released @azure-tools/test-recorder package has some issues.
cc @HarshaNalluru

@qiaozha
Copy link
Member Author

qiaozha commented Sep 3, 2021

@joheredi @sarangan12 Could you help review the PR now ? the test recorder issue should have been resolved.

Copy link
Contributor

@sarangan12 sarangan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But, I am seeing your comment that the test recorder has some issues. If that is resolved, this PR could be merged,

@qiaozha
Copy link
Member Author

qiaozha commented Sep 8, 2021

Looks good. But, I am seeing your comment that the test recorder has some issues. If that is resolved, this PR could be merged,

That issue has been resolved.

@qiaozha qiaozha merged commit 1e147d0 into Azure:main Sep 8, 2021
@qiaozha qiaozha deleted the add-test-framework-for-mgmt-sdk branch September 8, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants