Add network profile in Spring payload. #10313

bowen5 · 2020-07-31T04:53:58Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-07-31T04:54:02Z

[Staging] Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'networkProfile' in response that was not found in the old version. New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2273:7 Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L2270:7

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-07-31T04:54:14Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-31T04:55:34Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-31T04:55:38Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fa6454c with merge commit 1103769. SDK Automation 13.0.17.20200619.4
️✔️sdk/appplatform/mgmt-v2019_05_01_preview [View full logs] [Release SDK Changes]

openapi-sdkautomation · 2020-07-31T04:55:39Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fa6454c with merge commit 1103769. SDK Automation 13.0.17.20200619.4
️✔️preview/appplatform/mgmt/2019-05-01-preview [View full logs] [Release SDK Changes]
- preview.appplatform.mgmt.2019-05-01-preview.zip

openapi-sdkautomation · 2020-07-31T04:55:40Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fa6454c with merge commit 1103769. SDK Automation 13.0.17.20200619.4

️✔️@azure/arm-appplatform [View full logs] [Release SDK Changes]

azure-arm-appplatform-1.0.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/appPlatformManagementClient.js → ./dist/arm-appplatform.js...
[npmPack] created ./dist/arm-appplatform.js in 489ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 2.1kB   esm/appPlatformManagementClient.js             
[npmPack] npm notice 2.7kB   esm/appPlatformManagementClientContext.js      
[npmPack] npm notice 11.0kB  esm/operations/apps.js                         
[npmPack] npm notice 1.0kB   esm/models/appsMappers.js                      
[npmPack] npm notice 171.8kB dist/arm-appplatform.js                        
[npmPack] npm notice 59.0kB  dist/arm-appplatform.min.js                    
[npmPack] npm notice 7.7kB   esm/operations/bindings.js                     
[npmPack] npm notice 1.0kB   esm/models/bindingsMappers.js                  
[npmPack] npm notice 6.2kB   esm/operations/certificates.js                 
[npmPack] npm notice 1.0kB   esm/models/certificatesMappers.js              
[npmPack] npm notice 9.1kB   esm/operations/customDomains.js                
[npmPack] npm notice 1.1kB   esm/models/customDomainsMappers.js             
[npmPack] npm notice 21.4kB  esm/operations/deployments.js                  
[npmPack] npm notice 1.0kB   esm/models/deploymentsMappers.js               
[npmPack] npm notice 345B    esm/models/index.js                            
[npmPack] npm notice 590B    esm/operations/index.js                        
[npmPack] npm notice 55.4kB  esm/models/mappers.js                          
[npmPack] npm notice 2.3kB   esm/operations/operations.js                   
[npmPack] npm notice 560B    esm/models/operationsMappers.js                
[npmPack] npm notice 3.5kB   esm/models/parameters.js                       
[npmPack] npm notice 995B    rollup.config.js                               
[npmPack] npm notice 17.1kB  esm/operations/services.js                     
[npmPack] npm notice 1.1kB   esm/models/servicesMappers.js                  
[npmPack] npm notice 2.4kB   esm/operations/skuOperations.js                
[npmPack] npm notice 584B    esm/models/skuOperationsMappers.js             
[npmPack] npm notice 1.7kB   package.json                                   
[npmPack] npm notice 457B    tsconfig.json                                  
[npmPack] npm notice 881B    esm/appPlatformManagementClient.d.ts.map       
[npmPack] npm notice 1.2kB   esm/appPlatformManagementClient.js.map         
[npmPack] npm notice 521B    esm/appPlatformManagementClientContext.d.ts.map
[npmPack] npm notice 1.4kB   esm/appPlatformManagementClientContext.js.map  
[npmPack] npm notice 3.5kB   esm/operations/apps.d.ts.map                   
[npmPack] npm notice 5.6kB   esm/operations/apps.js.map                     
[npmPack] npm notice 541B    esm/models/appsMappers.d.ts.map                
[npmPack] npm notice 554B    esm/models/appsMappers.js.map                  
[npmPack] npm notice 355.2kB dist/arm-appplatform.js.map                    
[npmPack] npm notice 49.3kB  dist/arm-appplatform.min.js.map                
[npmPack] npm notice 3.7kB   esm/operations/bindings.d.ts.map               
[npmPack] npm notice 4.6kB   esm/operations/bindings.js.map                 
[npmPack] npm notice 536B    esm/models/bindingsMappers.d.ts.map            
[npmPack] npm notice 549B    esm/models/bindingsMappers.js.map              
[npmPack] npm notice 2.8kB   esm/operations/certificates.d.ts.map           
[npmPack] npm notice 3.6kB   esm/operations/certificates.js.map             
[npmPack] npm notice 544B    esm/models/certificatesMappers.d.ts.map        
[npmPack] npm notice 557B    esm/models/certificatesMappers.js.map          
[npmPack] npm notice 4.3kB   esm/operations/customDomains.d.ts.map          
[npmPack] npm notice 5.3kB   esm/operations/customDomains.js.map            
[npmPack] npm notice 572B    esm/models/customDomainsMappers.d.ts.map       
[npmPack] npm notice 585B    esm/models/customDomainsMappers.js.map         
[npmPack] npm notice 5.8kB   esm/operations/deployments.d.ts.map            
[npmPack] npm notice 9.9kB   esm/operations/deployments.js.map              
[npmPack] npm notice 555B    esm/models/deploymentsMappers.d.ts.map         
[npmPack] npm notice 568B    esm/models/deploymentsMappers.js.map           
[npmPack] npm notice 22.5kB  esm/models/index.d.ts.map                      
[npmPack] npm notice 290B    esm/operations/index.d.ts.map                  
[npmPack] npm notice 126B    esm/models/index.js.map                        
[npmPack] npm notice 305B    esm/operations/index.js.map                    
[npmPack] npm notice 3.1kB   esm/models/mappers.d.ts.map                    
[npmPack] npm notice 31.1kB  esm/models/mappers.js.map                      
[npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map             
[npmPack] npm notice 1.4kB   esm/operations/operations.js.map               
[npmPack] npm notice 277B    esm/models/operationsMappers.d.ts.map          
[npmPack] npm notice 290B    esm/models/operationsMappers.js.map            
[npmPack] npm notice 822B    esm/models/parameters.d.ts.map                 
[npmPack] npm notice 2.7kB   esm/models/parameters.js.map                   
[npmPack] npm notice 5.6kB   esm/operations/services.d.ts.map               
[npmPack] npm notice 9.1kB   esm/operations/services.js.map                 
[npmPack] npm notice 585B    esm/models/servicesMappers.d.ts.map            
[npmPack] npm notice 598B    esm/models/servicesMappers.js.map              
[npmPack] npm notice 1.0kB   esm/operations/skuOperations.d.ts.map          
[npmPack] npm notice 1.5kB   esm/operations/skuOperations.js.map            
[npmPack] npm notice 283B    esm/models/skuOperationsMappers.d.ts.map       
[npmPack] npm notice 296B    esm/models/skuOperationsMappers.js.map         
[npmPack] npm notice 3.4kB   README.md                                      
[npmPack] npm notice 1.4kB   esm/appPlatformManagementClient.d.ts           
[npmPack] npm notice 2.2kB   src/appPlatformManagementClient.ts             
[npmPack] npm notice 943B    esm/appPlatformManagementClientContext.d.ts    
[npmPack] npm notice 2.4kB   src/appPlatformManagementClientContext.ts      
[npmPack] npm notice 10.8kB  esm/operations/apps.d.ts                       
[npmPack] npm notice 18.6kB  src/operations/apps.ts                         
[npmPack] npm notice 715B    esm/models/appsMappers.d.ts                    
[npmPack] npm notice 1.1kB   src/models/appsMappers.ts                      
[npmPack] npm notice 11.4kB  esm/operations/bindings.d.ts                   
[npmPack] npm notice 18.7kB  src/operations/bindings.ts                     
[npmPack] npm notice 697B    esm/models/bindingsMappers.d.ts                
[npmPack] npm notice 1.0kB   src/models/bindingsMappers.ts                  
[npmPack] npm notice 8.5kB   esm/operations/certificates.d.ts

openapi-sdkautomation · 2020-07-31T04:55:41Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-31T04:55:45Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from fa6454c with merge commit 1103769. SDK Automation 13.0.17.20200619.4

⚠️azure-mgmt-appplatform [View full logs] [Release SDK Changes] Breaking Change Detected

[build_conf] INFO:packaging_tools:Building template azure-mgmt-appplatform
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-appplatform
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 33.108% size of original (original: 42548 chars, delta: 14087 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model AppResource has a new parameter location
[ChangeLog]   - Model AppResource has a new parameter identity
[ChangeLog]   - Model AppResourceProperties has a new parameter fqdn
[ChangeLog]   - Model AppResourceProperties has a new parameter https_only
[ChangeLog]   - Model OperationDetail has a new parameter is_data_action
[ChangeLog]   - Model ClusterResourceProperties has a new parameter network_profile
[ChangeLog]   - Model ServiceResource has a new parameter sku
[ChangeLog]   - Added operation group SkuOperations
[ChangeLog]   - Added operation group CustomDomainsOperations
[ChangeLog]   - Added operation group CertificatesOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Operation AppsOperations.create_or_update has a new signature
[ChangeLog]   - Operation AppsOperations.update has a new signature
[ChangeLog]   - Model OperationDetail no longer has parameter data_action

azuresdkci · 2020-07-31T04:56:27Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-07-31T04:59:08Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fa6454c with merge commit 1103769. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.AppPlatform [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.AppPlatform.0.1.0-preview.nupkg
- Microsoft.Azure.Management.AppPlatform.0.1.0-preview.snupkg

azure-pipelines · 2020-07-31T05:46:41Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-07-31T05:48:05Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-07-31T06:16:50Z

Azure Pipelines successfully started running 1 pipeline(s).

* Add network profile in Spring payload. * Fix prettier check. * Fix prettier.

Add network profile in Spring payload.

6353fe2

openapi-assignment-bot bot assigned njuCZ Jul 31, 2020

bowen5 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 31, 2020

This was referenced Jul 31, 2020

[AutoPR @azure/arm-appplatform] Add network profile in Spring payload. AzureSDKAutomation/azure-sdk-for-js#1615

Closed

[AutoPR sdk/appplatform/mgmt-v2019_05_01_preview] Add network profile in Spring payload. AzureSDKAutomation/azure-sdk-for-java#3576

Closed

This was referenced Jul 31, 2020

[AutoPR azure-mgmt-appplatform] Add network profile in Spring payload. AzureSDKAutomation/azure-sdk-for-python#1693

Closed

[AutoPR Microsoft.Azure.Management.AppPlatform] Add network profile in Spring payload. AzureSDKAutomation/azure-sdk-for-net#1473

Closed

Fix prettier check.

f97800a

Fix prettier.

fa6454c

njuCZ approved these changes Aug 3, 2020

View reviewed changes

njuCZ added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 3, 2020

njuCZ merged commit 1103769 into Azure:master Aug 3, 2020

njuCZ removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 3, 2020

bowen5 deleted the dev-appplatform-Microsoft.AppPlatform-2019-05-01-preview-vnet branch August 3, 2020 06:41

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Add network profile in Spring payload. (Azure#10313)

2b4f3b9

* Add network profile in Spring payload. * Fix prettier check. * Fix prettier.

Add network profile in Spring payload. #10313

Add network profile in Spring payload. #10313

Uh oh!

Conversation

bowen5 commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Staging] Swagger Validation Report

Uh oh!

azure-pipelines bot commented Jul 31, 2020

Uh oh!

openapi-sdkautomation bot commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

openapi-sdkautomation bot commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

- Breaking Change detected in SDK

Uh oh!

azuresdkci commented Jul 31, 2020

Uh oh!

openapi-sdkautomation bot commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

azure-pipelines bot commented Jul 31, 2020

Uh oh!

openapi-sdkautomation bot commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

azure-pipelines bot commented Jul 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bowen5 commented Jul 31, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 31, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 31, 2020 •

edited

Loading