-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[Hub Generated] Review request for Microsoft.AppPlatform to add version stable/2020-07-01 #10320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.AppPlatform to add version stable/2020-07-01 #10320
Conversation
…9-05-01-preview to version 2020-07-01
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
@majastrz , would you please help to sign off this PR? The content of this PR actually has been already signed off in private repo here https://github.com/Azure/azure-rest-api-specs-pr/pull/1627. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the first commit the original API version. It makes it much easier to review. The delta looks good. Signed off from ARM side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also add a new tag entry in the readme.go.md since you are requesting this package to be released in go SDK?
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@ArcturusZhang Thanks, just updated. |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas - Release
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your new api-version should be stable, but the output-folder is accidentally in preview sub-directory
Remove "perview" term in output path. Co-authored-by: Arcturus <[email protected]>
Azure Pipelines successfully started running 1 pipeline(s). |
…on stable/2020-07-01 (Azure#10320) * Fix swagger to add readonly for properties. * Adds base for updating Microsoft.AppPlatform from version preview/2019-05-01-preview to version 2020-07-01 * Updates readme * Updates API version in new specs and examples * Add new stable API version 2020-07-01. * Fix warnings. * Fix Prettier Check. * Fix Prettier Check. * Add multi-api entries in code generation config * Update package tag name * update python namespace * Update specification/appplatform/resource-manager/readme.go.md Remove "perview" term in output path. Co-authored-by: Arcturus <[email protected]> Co-authored-by: Yuwei Zhou <[email protected]> Co-authored-by: Arcturus <[email protected]>
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Private PR has been signed off by ARM: https://github.com/Azure/azure-rest-api-specs-pr/pull/1627
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on PR review process.