Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

bowen5
Copy link
Contributor

@bowen5 bowen5 commented Aug 2, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Private PR has been signed off by ARM: https://github.com/Azure/azure-rest-api-specs-pr/pull/1627

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 2, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 2, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 2, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 2, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 2, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 41967d1 with merge commit 12be731. SDK Automation 13.0.17.20200807.2
  • ️✔️azure-mgmt-appplatform [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-appplatform
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-appplatform
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 0.007% size of original (original: 29975 chars, delta: 2 chars)
    [ChangeLog] 

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 2, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 2, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 41967d1 with merge commit 12be731. SDK Automation 13.0.17.20200807.2
  • ️✔️@azure/arm-appplatform [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/appPlatformManagementClient.js → ./dist/arm-appplatform.js...
    [npmPack] created ./dist/arm-appplatform.js in 515ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 2.2kB   esm/appPlatformManagementClient.js             
    [npmPack] npm notice 2.7kB   esm/appPlatformManagementClientContext.js      
    [npmPack] npm notice 13.5kB  esm/operations/apps.js                         
    [npmPack] npm notice 1.1kB   esm/models/appsMappers.js                      
    [npmPack] npm notice 207.9kB dist/arm-appplatform.js                        
    [npmPack] npm notice 66.7kB  dist/arm-appplatform.min.js                    
    [npmPack] npm notice 12.2kB  esm/operations/bindings.js                     
    [npmPack] npm notice 1.1kB   esm/models/bindingsMappers.js                  
    [npmPack] npm notice 9.0kB   esm/operations/certificates.js                 
    [npmPack] npm notice 1.1kB   esm/models/certificatesMappers.js              
    [npmPack] npm notice 7.0kB   esm/operations/configServers.js                
    [npmPack] npm notice 1.0kB   esm/models/configServersMappers.js             
    [npmPack] npm notice 12.5kB  esm/operations/customDomains.js                
    [npmPack] npm notice 1.1kB   esm/models/customDomainsMappers.js             
    [npmPack] npm notice 22.8kB  esm/operations/deployments.js                  
    [npmPack] npm notice 1.1kB   esm/models/deploymentsMappers.js               
    [npmPack] npm notice 345B    esm/models/index.js                            
    [npmPack] npm notice 652B    esm/operations/index.js                        
    [npmPack] npm notice 56.0kB  esm/models/mappers.js                          
    [npmPack] npm notice 7.3kB   esm/operations/monitoringSettings.js           
    [npmPack] npm notice 1.1kB   esm/models/monitoringSettingsMappers.js        
    [npmPack] npm notice 2.3kB   esm/operations/operations.js                   
    [npmPack] npm notice 560B    esm/models/operationsMappers.js                
    [npmPack] npm notice 3.5kB   esm/models/parameters.js                       
    [npmPack] npm notice 995B    rollup.config.js                               
    [npmPack] npm notice 17.2kB  esm/operations/services.js                     
    [npmPack] npm notice 1.2kB   esm/models/servicesMappers.js                  
    [npmPack] npm notice 2.3kB   esm/operations/skus.js                         
    [npmPack] npm notice 575B    esm/models/skusMappers.js                      
    [npmPack] npm notice 1.7kB   package.json                                   
    [npmPack] npm notice 457B    tsconfig.json                                  
    [npmPack] npm notice 957B    esm/appPlatformManagementClient.d.ts.map       
    [npmPack] npm notice 1.3kB   esm/appPlatformManagementClient.js.map         
    [npmPack] npm notice 521B    esm/appPlatformManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/appPlatformManagementClientContext.js.map  
    [npmPack] npm notice 3.9kB   esm/operations/apps.d.ts.map                   
    [npmPack] npm notice 6.7kB   esm/operations/apps.js.map                     
    [npmPack] npm notice 596B    esm/models/appsMappers.d.ts.map                
    [npmPack] npm notice 609B    esm/models/appsMappers.js.map                  
    [npmPack] npm notice 387.4kB dist/arm-appplatform.js.map                    
    [npmPack] npm notice 55.0kB  dist/arm-appplatform.min.js.map                
    [npmPack] npm notice 3.1kB   esm/operations/bindings.d.ts.map               
    [npmPack] npm notice 5.6kB   esm/operations/bindings.js.map                 
    [npmPack] npm notice 565B    esm/models/bindingsMappers.d.ts.map            
    [npmPack] npm notice 578B    esm/models/bindingsMappers.js.map              
    [npmPack] npm notice 2.4kB   esm/operations/certificates.d.ts.map           
    [npmPack] npm notice 4.2kB   esm/operations/certificates.js.map             
    [npmPack] npm notice 573B    esm/models/certificatesMappers.d.ts.map        
    [npmPack] npm notice 586B    esm/models/certificatesMappers.js.map          
    [npmPack] npm notice 1.6kB   esm/operations/configServers.d.ts.map          
    [npmPack] npm notice 3.1kB   esm/operations/configServers.js.map            
    [npmPack] npm notice 562B    esm/models/configServersMappers.d.ts.map       
    [npmPack] npm notice 575B    esm/models/configServersMappers.js.map         
    [npmPack] npm notice 3.1kB   esm/operations/customDomains.d.ts.map          
    [npmPack] npm notice 5.6kB   esm/operations/customDomains.js.map            
    [npmPack] npm notice 575B    esm/models/customDomainsMappers.d.ts.map       
    [npmPack] npm notice 588B    esm/models/customDomainsMappers.js.map         
    [npmPack] npm notice 5.6kB   esm/operations/deployments.d.ts.map            
    [npmPack] npm notice 10.3kB  esm/operations/deployments.js.map              
    [npmPack] npm notice 584B    esm/models/deploymentsMappers.d.ts.map         
    [npmPack] npm notice 597B    esm/models/deploymentsMappers.js.map           
    [npmPack] npm notice 25.5kB  esm/models/index.d.ts.map                      
    [npmPack] npm notice 334B    esm/operations/index.d.ts.map                  
    [npmPack] npm notice 126B    esm/models/index.js.map                        
    [npmPack] npm notice 349B    esm/operations/index.js.map                    
    [npmPack] npm notice 3.2kB   esm/models/mappers.d.ts.map                    
    [npmPack] npm notice 31.5kB  esm/models/mappers.js.map                      
    [npmPack] npm notice 1.6kB   esm/operations/monitoringSettings.d.ts.map     
    [npmPack] npm notice 3.1kB   esm/operations/monitoringSettings.js.map       
    [npmPack] npm notice 572B    esm/models/monitoringSettingsMappers.d.ts.map  
    [npmPack] npm notice 585B    esm/models/monitoringSettingsMappers.js.map    
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map             
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map               
    [npmPack] npm notice 277B    esm/models/operationsMappers.d.ts.map          
    [npmPack] npm notice 290B    esm/models/operationsMappers.js.map            
    [npmPack] npm notice 822B    esm/models/parameters.d.ts.map                 
    [npmPack] npm notice 2.7kB   esm/models/parameters.js.map                   
    [npmPack] npm notice 5.6kB   esm/operations/services.d.ts.map               
    [npmPack] npm notice 9.1kB   esm/operations/services.js.map                 
    [npmPack] npm notice 614B    esm/models/servicesMappers.d.ts.map            
    [npmPack] npm notice 627B    esm/models/servicesMappers.js.map              
    [npmPack] npm notice 1.0kB   esm/operations/skus.d.ts.map                   
    [npmPack] npm notice 1.4kB   esm/operations/skus.js.map                     
    [npmPack] npm notice 265B    esm/models/skusMappers.d.ts.map                
    [npmPack] npm notice 278B    esm/models/skusMappers.js.map                  
    [npmPack] npm notice 3.4kB   README.md                                      
    [npmPack] npm notice 1.5kB   esm/appPlatformManagementClient.d.ts           

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 2, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 2, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bowen5 bowen5 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 2, 2020
@njuCZ njuCZ added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 3, 2020
@bowen5
Copy link
Contributor Author

bowen5 commented Aug 3, 2020

@majastrz , would you please help to sign off this PR? The content of this PR actually has been already signed off in private repo here https://github.com/Azure/azure-rest-api-specs-pr/pull/1627. Thank you!

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the first commit the original API version. It makes it much easier to review. The delta looks good. Signed off from ARM side.

@majastrz majastrz removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 3, 2020
@majastrz majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 3, 2020
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add a new tag entry in the readme.go.md since you are requesting this package to be released in go SDK?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yuwzho
Copy link
Contributor

yuwzho commented Aug 11, 2020

Could you please also add a new tag entry in the readme.go.md since you are requesting this package to be released in go SDK?

@ArcturusZhang Thanks, just updated.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bowen5 bowen5 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 17, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 17, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 41967d1 with merge commit 12be731. Schema Automation 13.0.17.20200807.2
  • ️✔️appplatform [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5605 passing (1m)
      AzureResourceSchema has no registered package commands.

    Copy link
    Member

    @ArcturusZhang ArcturusZhang left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Your new api-version should be stable, but the output-folder is accidentally in preview sub-directory

    Remove "perview" term in output path.
    
    Co-authored-by: Arcturus <[email protected]>
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @bowen5 bowen5 requested a review from ArcturusZhang August 17, 2020 05:30
    @njuCZ njuCZ merged commit 12be731 into Azure:master Aug 17, 2020
    innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020
    …on stable/2020-07-01 (Azure#10320)
    
    * Fix swagger to add readonly for properties.
    
    * Adds base for updating Microsoft.AppPlatform from version preview/2019-05-01-preview to version 2020-07-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add new stable API version 2020-07-01.
    
    * Fix warnings.
    
    * Fix Prettier Check.
    
    * Fix Prettier Check.
    
    * Add multi-api entries in code generation config
    
    * Update package tag name
    
    * update python namespace
    
    * Update specification/appplatform/resource-manager/readme.go.md
    
    Remove "perview" term in output path.
    
    Co-authored-by: Arcturus <[email protected]>
    
    Co-authored-by: Yuwei Zhou <[email protected]>
    Co-authored-by: Arcturus <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    6 participants