Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

abhinav-ghai
Copy link
Member

@abhinav-ghai abhinav-ghai commented Aug 5, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 5, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 5, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 5, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ff9a179 with merge commit 38dd0db. SDK Automation 13.0.17.20200807.2
  • ️✔️@azure/arm-automanage [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/automanageClient.js → ./dist/arm-automanage.js...
    [npmPack] created ./dist/arm-automanage.js in 212ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 6.8kB   esm/operations/accounts.js                                
    [npmPack] npm notice 793B    esm/models/accountsMappers.js                             
    [npmPack] npm notice 58.1kB  dist/arm-automanage.js                                    
    [npmPack] npm notice 20.3kB  dist/arm-automanage.min.js                                
    [npmPack] npm notice 1.8kB   esm/automanageClient.js                                   
    [npmPack] npm notice 2.6kB   esm/automanageClientContext.js                            
    [npmPack] npm notice 8.4kB   esm/operations/configurationProfileAssignments.js         
    [npmPack] npm notice 839B    esm/models/configurationProfileAssignmentsMappers.js      
    [npmPack] npm notice 7.9kB   esm/operations/configurationProfilePreferences.js         
    [npmPack] npm notice 839B    esm/models/configurationProfilePreferencesMappers.js      
    [npmPack] npm notice 345B    esm/models/index.js                                       
    [npmPack] npm notice 511B    esm/operations/index.js                                   
    [npmPack] npm notice 14.9kB  esm/models/mappers.js                                     
    [npmPack] npm notice 1.5kB   esm/operations/operations.js                              
    [npmPack] npm notice 471B    esm/models/operationsMappers.js                           
    [npmPack] npm notice 2.2kB   esm/models/parameters.js                                  
    [npmPack] npm notice 982B    rollup.config.js                                          
    [npmPack] npm notice 1.6kB   package.json                                              
    [npmPack] npm notice 457B    tsconfig.json                                             
    [npmPack] npm notice 3.0kB   esm/operations/accounts.d.ts.map                          
    [npmPack] npm notice 4.1kB   esm/operations/accounts.js.map                            
    [npmPack] npm notice 350B    esm/models/accountsMappers.d.ts.map                       
    [npmPack] npm notice 363B    esm/models/accountsMappers.js.map                         
    [npmPack] npm notice 123.9kB dist/arm-automanage.js.map                                
    [npmPack] npm notice 17.1kB  dist/arm-automanage.min.js.map                            
    [npmPack] npm notice 723B    esm/automanageClient.d.ts.map                             
    [npmPack] npm notice 877B    esm/automanageClient.js.map                               
    [npmPack] npm notice 499B    esm/automanageClientContext.d.ts.map                      
    [npmPack] npm notice 1.4kB   esm/automanageClientContext.js.map                        
    [npmPack] npm notice 2.5kB   esm/operations/configurationProfileAssignments.d.ts.map   
    [npmPack] npm notice 3.9kB   esm/operations/configurationProfileAssignments.js.map     
    [npmPack] npm notice 399B    esm/models/configurationProfileAssignmentsMappers.d.ts.map
    [npmPack] npm notice 412B    esm/models/configurationProfileAssignmentsMappers.js.map  
    [npmPack] npm notice 3.1kB   esm/operations/configurationProfilePreferences.d.ts.map   
    [npmPack] npm notice 4.2kB   esm/operations/configurationProfilePreferences.js.map     
    [npmPack] npm notice 399B    esm/models/configurationProfilePreferencesMappers.d.ts.map
    [npmPack] npm notice 412B    esm/models/configurationProfilePreferencesMappers.js.map  
    [npmPack] npm notice 6.7kB   esm/models/index.d.ts.map                                 
    [npmPack] npm notice 204B    esm/operations/index.d.ts.map                             
    [npmPack] npm notice 126B    esm/models/index.js.map                                   
    [npmPack] npm notice 219B    esm/operations/index.js.map                               
    [npmPack] npm notice 1.2kB   esm/models/mappers.d.ts.map                               
    [npmPack] npm notice 8.4kB   esm/models/mappers.js.map                                 
    [npmPack] npm notice 659B    esm/operations/operations.d.ts.map                        
    [npmPack] npm notice 906B    esm/operations/operations.js.map                          
    [npmPack] npm notice 225B    esm/models/operationsMappers.d.ts.map                     
    [npmPack] npm notice 238B    esm/models/operationsMappers.js.map                       
    [npmPack] npm notice 543B    esm/models/parameters.d.ts.map                            
    [npmPack] npm notice 1.5kB   esm/models/parameters.js.map                              
    [npmPack] npm notice 3.4kB   README.md                                                 
    [npmPack] npm notice 6.9kB   esm/operations/accounts.d.ts                              
    [npmPack] npm notice 13.5kB  src/operations/accounts.ts                                
    [npmPack] npm notice 483B    esm/models/accountsMappers.d.ts                           
    [npmPack] npm notice 783B    src/models/accountsMappers.ts                             
    [npmPack] npm notice 1.2kB   esm/automanageClient.d.ts                                 
    [npmPack] npm notice 1.9kB   src/automanageClient.ts                                   
    [npmPack] npm notice 890B    esm/automanageClientContext.d.ts                          
    [npmPack] npm notice 2.4kB   src/automanageClientContext.ts                            
    [npmPack] npm notice 6.9kB   esm/operations/configurationProfileAssignments.d.ts       
    [npmPack] npm notice 13.3kB  src/operations/configurationProfileAssignments.ts         
    [npmPack] npm notice 529B    esm/models/configurationProfileAssignmentsMappers.d.ts    
    [npmPack] npm notice 806B    src/models/configurationProfileAssignmentsMappers.ts      
    [npmPack] npm notice 8.5kB   esm/operations/configurationProfilePreferences.d.ts       
    [npmPack] npm notice 16.3kB  src/operations/configurationProfilePreferences.ts         
    [npmPack] npm notice 529B    esm/models/configurationProfilePreferencesMappers.d.ts    
    [npmPack] npm notice 806B    src/models/configurationProfilePreferencesMappers.ts      
    [npmPack] npm notice 18.0kB  esm/models/index.d.ts                                     
    [npmPack] npm notice 195B    esm/operations/index.d.ts                                 
    [npmPack] npm notice 17.4kB  src/models/index.ts                                       
    [npmPack] npm notice 479B    src/operations/index.ts                                   
    [npmPack] npm notice 1.6kB   esm/models/mappers.d.ts                                   
    [npmPack] npm notice 12.3kB  src/models/mappers.ts                                     
    [npmPack] npm notice 1.1kB   esm/operations/operations.d.ts                            
    [npmPack] npm notice 2.3kB   src/operations/operations.ts                              
    [npmPack] npm notice 161B    esm/models/operationsMappers.d.ts                         
    [npmPack] npm notice 437B    src/models/operationsMappers.ts                           
    [npmPack] npm notice 648B    esm/models/parameters.d.ts                                
    [npmPack] npm notice 2.2kB   src/models/parameters.ts                                  
    [npmPack] npm notice 1.1kB   LICENSE.txt                                               
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-automanage                   
    [npmPack] npm notice version:       1.0.0                                   
    [npmPack] npm notice filename:      azure-arm-automanage-1.0.0.tgz          
    [npmPack] npm notice package size:  52.5 kB                                 
    [npmPack] npm notice unpacked size: 457.3 kB                                
    [npmPack] npm notice shasum:        5859559dbe5a136432725116ee7ac709491b0c1e
    [npmPack] npm notice integrity:     sha512-g1i333DfO9gAq[...]aqJv6a64lDyKg==

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 5, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 5, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 5, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from ff9a179 with merge commit 38dd0db. SDK Automation 13.0.17.20200807.2
    [azure-mgmt-automanage][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-automanage [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-automanage
    [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-automanage
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-automanage
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    Not exact 2 reports found:
    code_reports/latest/report.json
    Not generating changelog.
    [ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 5, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 5, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ff9a179 with merge commit 38dd0db. SDK Automation 13.0.17.20200807.2
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Automanage [View full logs]  [Release SDK Changes]
      No Artifact Generated.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 5, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 5, 2020
    @abhinav-ghai
    Copy link
    Member Author

    1 Lint error, I believe tool is catching it incorrectly since we have an extension provider resource type for Microsoft.Compute:

    PathResourceProviderMatchNamespace
    The last resource provider 'Microsoft.Automanage, Microsoft.Compute' doesn't match the namespace.

    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Reviewed delta between the already approved PR (https://github.com/Azure/azure-rest-api-specs-pr/pull/1283) and this one and it looks good to me. Signed off from ARM side.

    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 5, 2020
    @fengzhou-msft
    Copy link
    Member

    @abhinav-ghai please fix the LintDiff error.

    @abhinav-ghai
    Copy link
    Member Author

    @abhinav-ghai please fix the LintDiff error.

    I think this error is caught incorrectly by tool. This path is for a extension resource type which will have two provider names in correct order. The tool is incorrect in marking this as error.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @fengzhou-msft
    Copy link
    Member

    @raych1 can you help to take a look at the LintDiff error in this PR. According to @abhinav-ghai's comments above, it should not be an error.

    @raych1
    Copy link
    Member

    raych1 commented Aug 10, 2020

    @abhinav-ghai , can you refer to rule4018 for the fix on lintDiff failures? /CC @jianyexi

    @azure-pipelines
    Copy link

    Pull request contains merge conflicts.

    @azure-pipelines
    Copy link

    Pull request contains merge conflicts.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @raych1
    Copy link
    Member

    raych1 commented Aug 13, 2020

    @jianyexi , lintDiff passed in unified pipeline run. Can you advise on this PR merge?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    5 participants