Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Aug 13, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 13, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from bd738da with merge commit 23294a6. SDK Automation 13.0.17.20200807.2
  • ⚠️azure-mgmt-hybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-hybridcompute
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-hybridcompute
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 68.214% size of original (original: 24429 chars, delta: 16664 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model MachineUpdate has a new parameter location_data
    [ChangeLog]   - Model Machine has a new parameter location_data
    [ChangeLog]   - Model Machine has a new parameter identity
    [ChangeLog]   - Added operation group MachineExtensionsOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Model MachineUpdate no longer has parameter physical_location
    [ChangeLog]   - Model MachineExtension no longer has parameter type1
    [ChangeLog]   - Model MachineExtension no longer has parameter principal_id
    [ChangeLog]   - Model MachineExtension no longer has parameter tenant_id
    [ChangeLog]   - Model Resource no longer has parameter tags
    [ChangeLog]   - Model Resource no longer has parameter tenant_id
    [ChangeLog]   - Model Resource no longer has parameter type1
    [ChangeLog]   - Model Resource no longer has parameter location
    [ChangeLog]   - Model Resource no longer has parameter principal_id
    [ChangeLog]   - Model Machine no longer has parameter type1
    [ChangeLog]   - Model Machine no longer has parameter principal_id
    [ChangeLog]   - Model Machine no longer has parameter physical_location
    [ChangeLog]   - Model Machine no longer has parameter tenant_id
    [ChangeLog]   - Model ErrorResponse has a new signature

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from bd738da with merge commit 23294a6. SDK Automation 13.0.17.20200807.2
  • ️✔️@azure/arm-hybridcompute [View full logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/hybridComputeManagementClient.js → ./dist/arm-hybridcompute.js...
    [npmPack] created ./dist/arm-hybridcompute.js in 334ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 77.7kB  dist/arm-hybridcompute.js                        
    [npmPack] npm notice 26.9kB  dist/arm-hybridcompute.min.js                    
    [npmPack] npm notice 1.7kB   esm/hybridComputeManagementClient.js             
    [npmPack] npm notice 2.6kB   esm/hybridComputeManagementClientContext.js      
    [npmPack] npm notice 345B    esm/models/index.js                              
    [npmPack] npm notice 446B    esm/operations/index.js                          
    [npmPack] npm notice 11.1kB  esm/operations/machineExtensions.js              
    [npmPack] npm notice 973B    esm/models/machineExtensionsMappers.js           
    [npmPack] npm notice 5.9kB   esm/operations/machines.js                       
    [npmPack] npm notice 923B    esm/models/machinesMappers.js                    
    [npmPack] npm notice 37.6kB  esm/models/mappers.js                            
    [npmPack] npm notice 1.6kB   esm/operations/operations.js                     
    [npmPack] npm notice 466B    esm/models/operationsMappers.js                  
    [npmPack] npm notice 2.1kB   esm/models/parameters.js                         
    [npmPack] npm notice 1.0kB   rollup.config.js                                 
    [npmPack] npm notice 1.7kB   package.json                                     
    [npmPack] npm notice 457B    tsconfig.json                                    
    [npmPack] npm notice 151.6kB dist/arm-hybridcompute.js.map                    
    [npmPack] npm notice 22.9kB  dist/arm-hybridcompute.min.js.map                
    [npmPack] npm notice 708B    esm/hybridComputeManagementClient.d.ts.map       
    [npmPack] npm notice 832B    esm/hybridComputeManagementClient.js.map         
    [npmPack] npm notice 524B    esm/hybridComputeManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/hybridComputeManagementClientContext.js.map  
    [npmPack] npm notice 11.4kB  esm/models/index.d.ts.map                        
    [npmPack] npm notice 181B    esm/operations/index.d.ts.map                    
    [npmPack] npm notice 126B    esm/models/index.js.map                          
    [npmPack] npm notice 196B    esm/operations/index.js.map                      
    [npmPack] npm notice 2.8kB   esm/operations/machineExtensions.d.ts.map        
    [npmPack] npm notice 5.2kB   esm/operations/machineExtensions.js.map          
    [npmPack] npm notice 489B    esm/models/machineExtensionsMappers.d.ts.map     
    [npmPack] npm notice 502B    esm/models/machineExtensionsMappers.js.map       
    [npmPack] npm notice 2.7kB   esm/operations/machines.d.ts.map                 
    [npmPack] npm notice 3.7kB   esm/operations/machines.js.map                   
    [npmPack] npm notice 452B    esm/models/machinesMappers.d.ts.map              
    [npmPack] npm notice 465B    esm/models/machinesMappers.js.map                
    [npmPack] npm notice 2.0kB   esm/models/mappers.d.ts.map                      
    [npmPack] npm notice 21.2kB  esm/models/mappers.js.map                        
    [npmPack] npm notice 663B    esm/operations/operations.d.ts.map               
    [npmPack] npm notice 908B    esm/operations/operations.js.map                 
    [npmPack] npm notice 215B    esm/models/operationsMappers.d.ts.map            
    [npmPack] npm notice 228B    esm/models/operationsMappers.js.map              
    [npmPack] npm notice 539B    esm/models/parameters.d.ts.map                   
    [npmPack] npm notice 1.6kB   esm/models/parameters.js.map                     
    [npmPack] npm notice 3.5kB   README.md                                        
    [npmPack] npm notice 1.2kB   esm/hybridComputeManagementClient.d.ts           
    [npmPack] npm notice 1.7kB   src/hybridComputeManagementClient.ts             
    [npmPack] npm notice 834B    esm/hybridComputeManagementClientContext.d.ts    
    [npmPack] npm notice 2.3kB   src/hybridComputeManagementClientContext.ts      
    [npmPack] npm notice 33.9kB  esm/models/index.d.ts                            
    [npmPack] npm notice 130B    esm/operations/index.d.ts                        
    [npmPack] npm notice 32.5kB  src/models/index.ts                              
    [npmPack] npm notice 414B    src/operations/index.ts                          
    [npmPack] npm notice 8.0kB   esm/operations/machineExtensions.d.ts            
    [npmPack] npm notice 14.9kB  src/operations/machineExtensions.ts              
    [npmPack] npm notice 663B    esm/models/machineExtensionsMappers.d.ts         
    [npmPack] npm notice 976B    src/models/machineExtensionsMappers.ts           
    [npmPack] npm notice 6.7kB   esm/operations/machines.d.ts                     
    [npmPack] npm notice 12.7kB  src/operations/machines.ts                       
    [npmPack] npm notice 613B    esm/models/machinesMappers.d.ts                  
    [npmPack] npm notice 931B    src/models/machinesMappers.ts                    
    [npmPack] npm notice 2.7kB   esm/models/mappers.d.ts                          
    [npmPack] npm notice 30.1kB  src/models/mappers.ts                            
    [npmPack] npm notice 1.1kB   esm/operations/operations.d.ts                   
    [npmPack] npm notice 2.4kB   src/operations/operations.ts                     
    [npmPack] npm notice 156B    esm/models/operationsMappers.d.ts                
    [npmPack] npm notice 430B    src/models/operationsMappers.ts                  
    [npmPack] npm notice 600B    esm/models/parameters.d.ts                       
    [npmPack] npm notice 2.1kB   src/models/parameters.ts                         
    [npmPack] npm notice 1.1kB   LICENSE.txt                                      
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-hybridcompute                
    [npmPack] npm notice version:       1.0.0                                   
    [npmPack] npm notice filename:      azure-arm-hybridcompute-1.0.0.tgz       
    [npmPack] npm notice package size:  65.8 kB                                 
    [npmPack] npm notice unpacked size: 569.7 kB                                
    [npmPack] npm notice shasum:        b91c747ff85358e27566164910522cd13003c614
    [npmPack] npm notice integrity:     sha512-jX6N4YPofuVKg[...]VaPYCw0oDaxsA==
    [npmPack] npm notice total files:   69                                      
    [npmPack] npm notice 

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from bd738da with merge commit 23294a6. Schema Automation 13.0.17.20200807.2
  • ️✔️hybridcompute [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5613 passing (1m)
      AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    azure-sdk-for-python

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 3cae78a with merge commit da9fb39ce79ff23f1914363959dcd2be8441cdbc. SDK Automation 13.0.17.20200807.2
    • ⚠️azure-mgmt-hybridcompute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-hybridcompute
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-hybridcompute
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 68.214% size of original (original: 24429 chars, delta: 16664 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model MachineUpdate has a new parameter location_data
      [ChangeLog]   - Model Machine has a new parameter location_data
      [ChangeLog]   - Model Machine has a new parameter identity
      [ChangeLog]   - Added operation group MachineExtensionsOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Model MachineExtension no longer has parameter principal_id
      [ChangeLog]   - Model MachineExtension no longer has parameter tenant_id
      [ChangeLog]   - Model MachineExtension no longer has parameter type1
      [ChangeLog]   - Model MachineUpdate no longer has parameter physical_location
      [ChangeLog]   - Model Machine no longer has parameter principal_id
      [ChangeLog]   - Model Machine no longer has parameter tenant_id
      [ChangeLog]   - Model Machine no longer has parameter physical_location
      [ChangeLog]   - Model Machine no longer has parameter type1
      [ChangeLog]   - Model Resource no longer has parameter tags
      [ChangeLog]   - Model Resource no longer has parameter type1
      [ChangeLog]   - Model Resource no longer has parameter location
      [ChangeLog]   - Model Resource no longer has parameter tenant_id
      [ChangeLog]   - Model Resource no longer has parameter principal_id
      [ChangeLog]   - Model ErrorResponse has a new signature

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from bd738da with merge commit 23294a6. SDK Automation 13.0.17.20200807.2
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.HybridCompute [View full logs]  [Release SDK Changes]
        No Artifact Generated.

      @azuresdkci
      Copy link
      Contributor

      Can one of the admins verify this patch?

      @TylerLeonhardt TylerLeonhardt marked this pull request as ready for review August 13, 2020 18:16
      @TylerLeonhardt TylerLeonhardt requested a review from farehar August 13, 2020 18:17
      @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 13, 2020
      @TylerLeonhardt TylerLeonhardt removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 13, 2020
      @TylerLeonhardt TylerLeonhardt changed the title move to readme.*.md files Update HybridCompute generation docs Aug 13, 2020

      ``` yaml
      package-name: azure_mgmt_hybridcompute
      package-version: "0.17.1"
      Copy link
      Contributor

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      Any specific reason why we're setting the version as .17.1?

      Copy link
      Member Author

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      oops bad copy paste

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 17, 2020

      azure-sdk-for-python-track2 - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @erich-wang erich-wang merged commit 23294a6 into Azure:master Aug 18, 2020
      @TylerLeonhardt TylerLeonhardt deleted the update-hybridcompute-spec-extensions branch August 18, 2020 15:14
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Projects

      None yet

      Development

      Successfully merging this pull request may close these issues.

      4 participants