Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

innosam
Copy link
Contributor

@innosam innosam commented Aug 28, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 28, 2020

[Staging] Swagger Validation Report

BreakingChange: 19 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L932:5
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L932:5
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1547:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1543:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L983:5
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L982:5
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L999:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L997:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1002:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1000:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1013:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1010:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1002:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1000:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1547:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1543:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1552:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1547:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1557:9
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1551:9
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 28, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from ac41d11 with merge commit 4e96148. SDK Automation 13.0.17.20200828.8
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1892: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 31 Aug 2020 23:35:28 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0788:080D:38EDF5F:60876FA:5F4D893F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4653","x-ratelimit-reset":"1598917336","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-regionmove@10627","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1902: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 31 Aug 2020 23:35:28 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0785:5D46:1FCD330:485904F:5F4D893F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4649","x-ratelimit-reset":"1598917336","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-regionmove@10627","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1901: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 31 Aug 2020 23:35:28 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0787:61B4:3D1AA1C:6532AAA:5F4D893F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4647","x-ratelimit-reset":"1598917336","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-regionmove@10627","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1893: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 31 Aug 2020 23:35:29 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0782:0C71:3B10054:643ED10:5F4D8940","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4646","x-ratelimit-reset":"1598917336","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-regionmove@10627","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    [azure-mgmt-regionmove][breaking_change_report_pypi] WARNING:__main__:Version 1.0.0b1 seems to be too old to build a report (probably not Autorest based)
    [azure-mgmt-regionmove][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-regionmove [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-regionmove
    [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-regionmove
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-regionmove
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
    [build_package]   normalized_version,
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
    [build_package]   normalized_version,
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [breaking_change_report_pypi] WARNING:__main__:Version 1.0.0b1 seems to be too old to build a report (probably not Autorest based)
    Not exact 2 reports found:
    code_reports/latest/report.json
    Not generating changelog.
    [ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 28, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ac41d11 with merge commit 4e96148. Schema Automation 13.0.17.20200828.8
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-resource-manager-schemas/pull/178: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 31 Aug 2020 23:34:59 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0586:39FF:20170F5:4C89E25:5F4D8923","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4822","x-ratelimit-reset":"1598917336","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-resource-manager-schemas/git/refs/heads/sdkAutomation/regionmove@10627","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
  • ️✔️regionmove [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5645 passing (1m)
      AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 28, 2020

    azure-sdk-for-net - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 28, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 28, 2020

    azure-sdk-for-java - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from ac41d11 with merge commit 4e96148. SDK Automation 13.0.17.20200828.8
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 28, 2020

    azure-sdk-for-js - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from ac41d11 with merge commit 4e96148. SDK Automation 13.0.17.20200828.8
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 28, 2020

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from ac41d11 with merge commit 4e96148. SDK Automation 13.0.17.20200828.8
      Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/8008: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 31 Aug 2020 23:36:31 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0785:438F:3DBC6F9:66EB156:5F4D897F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4546","x-ratelimit-reset":"1598917336","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/preview_regionmove_mgmt_2019-10-01-preview@10627","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    • ️✔️preview/regionmove/mgmt/2019-10-01-preview [View full logs]  [Release SDK Changes]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 28, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @innosam innosam marked this pull request as ready for review August 29, 2020 06:14
    @innosam
    Copy link
    Contributor Author

    innosam commented Aug 29, 2020

    Breaking-change:
    The service is in private preview, and we are doing this fixes/improvements as part of public preview that is tentatively planned on 23th September 2020. Additionally our private preview customer do not use the API's directly instead rely on the portal for the usage.
    We are also working on releasing auto generated PowerShell and SDK's so the swagger is being actively validated before public preview.

    Change Details:

    • The MoveResourceStatus and MoveResourceError are referred in the MoveResourceProperties and are referred as read only using the following pattern.

        "moveStatus": {
          "description": "Defines the move resource status.",
          "allOf": [
            {
              "$ref": "#/definitions/MoveResourceStatus"
            }
          ],
          "readOnly": true
        },
      

    However, due to a bug in PowerShell auto generation, it is not respecting the readOnly field, so a workaround is suggested to mark the individual properties of the MoveResourceStatus and Errors as read-only as well.

    Rule Message
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L932:5Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L932:5
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1547:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1543:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L983:5Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L982:5
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L999:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L997:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1002:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1000:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1013:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1010:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1002:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1000:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1547:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1543:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1552:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1547:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1557:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1551:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1562:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1555:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1552:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1547:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1557:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1551:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1562:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1555:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1562:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1555:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1022:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1019:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1547:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1543:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1552:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1547:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1557:9Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L1551:9

    @ArcturusZhang
    Copy link
    Member

    Approved breaking changes since this is a preview api-version within one year

    @ArcturusZhang ArcturusZhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 31, 2020
    @ArcturusZhang
    Copy link
    Member

    Hi @innosam this PR LGTM, please let me know if this is good to merge, thanks

    @innosam
    Copy link
    Contributor Author

    innosam commented Aug 31, 2020

    Hi @innosam this PR LGTM, please let me know if this is good to merge, thanks

    Thanks, please go ahead and merge.

    @innosam innosam closed this Aug 31, 2020
    @innosam innosam reopened this Aug 31, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 31, 2020

    azure-sdk-for-python-track2 - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from ac41d11 with merge commit 4e96148. SDK Automation 13.0.17.20200828.8
      Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1901: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 31 Aug 2020 23:35:28 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0408:0912:406050A:6A6B34E:5F4D893F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4650","x-ratelimit-reset":"1598917336","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-regionmove@10627","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
      Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1893: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 31 Aug 2020 23:35:29 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0406:61B3:1D1E5BC:45CDC65:5F4D893F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4644","x-ratelimit-reset":"1598917336","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-regionmove@10627","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveResourceProperties-sourceResourceSettings' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveResourceProperties-moveStatus' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveResourceProperties-errors' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'SubnetReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'LoadBalancerBackendAddressPoolReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'LoadBalancerNatRuleReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'SqlServerResourceSettings' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ResourceGroupResourceSettings' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceProperties-sourceResourceSettings' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceProperties-moveStatus' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceProperties-errors' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceFilterProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [track2_azure-mgmt-regionmove][breaking_change_report_pypi] WARNING:__main__:Version 1.0.0b1 seems to be too old to build a report (probably not Autorest based)
      [track2_azure-mgmt-regionmove][ChangeLog] WARNING: Failed to generate ChangeLog.
    • ⚠️azure-mgmt-regionmove [View full logs]  [Release SDK Changes]
      [build_conf_init]   Cache entry deserialization failed, entry ignored
      [build_conf_init]   Cache entry deserialization failed, entry ignored
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-regionmove
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-regionmove
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
      [build_package]   normalized_version,
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
      [build_package]   normalized_version,
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [breaking_change_report_pypi] WARNING:__main__:Version 1.0.0b1 seems to be too old to build a report (probably not Autorest based)
      Not exact 2 reports found:
      code_reports/latest/report.json
      Not generating changelog.
      [ChangeLog] WARNING: Failed to generate ChangeLog.

    @ArcturusZhang ArcturusZhang merged commit 4e96148 into Azure:master Aug 31, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants