Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

chinadragon0515
Copy link
Contributor

@chinadragon0515 chinadragon0515 commented Jan 16, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • [ Y] The title of the PR is clear and informative.
  • [ Y] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [ Y] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • [ NA] If applicable, the PR references the bug/issue that it fixes.
  • [ Y] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 1

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

"modelAsString": true
}
},
"customSetupScriptProperties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: For consistency, you can name the model with PascalCase and name the properties with camelCased letters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent, properties within definition are start with low case, so using low case here.
And definition are start with upper case, refer to link 208

@marstr marstr changed the base branch from current to master January 16, 2018 21:03
@dsgouda dsgouda merged commit 2e8af97 into Azure:master Jan 17, 2018
@AutorestCI
Copy link

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants