Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix key-vault data plane TypeScript output path #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Oct 23, 2018
Merged

Fix key-vault data plane TypeScript output path #4310

1 commit merged into from
Oct 23, 2018

Conversation

kpajdzik
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@kpajdzik kpajdzik requested a review from a user October 23, 2018 15:43
@kpajdzik kpajdzik requested a review from schaabs as a code owner October 23, 2018 15:43
@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Oct 23, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 23, 2018 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#281

@azuresdkci azuresdkci requested a review from praries880 October 23, 2018 15:44
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ghost ghost merged commit 9c1fe12 into master Oct 23, 2018
@ghost ghost deleted the kamip/keyvault-output-fix branch October 23, 2018 15:59
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@uratzmon
Use MI practices (#4310)
80044af 
* fix mi

* identity object outside of properties

* fix

* fix

* fix

* fix

* try to fix

* Revert "try to fix"

This reverts commit be92ab2a3f43e0f32543b231692311e7f2b9ee87.

* fsdf

* dfsf

* sfsdf
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaabs schaabs Awaiting requested review from schaabs

@praries880 praries880 Awaiting requested review from praries880

1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees

@praries880 praries880

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpajdzik @AutorestCI @azuresdkci @praries880