Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Storage] Fix the UseSubDomainName #4938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2018
Merged

[Storage] Fix the UseSubDomainName #4938

merged 1 commit into from
Dec 21, 2018

Conversation

blueww
Copy link
Member

@blueww blueww commented Dec 18, 2018 •
edited
Loading

This PR is to fix the issue Azure/azure-sdk-for-python#4013
The "useSubDomain" should be “useSubDomainName” from day one.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@blueww blueww requested a review from lmazuel December 18, 2018 03:46
@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#553

@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2111

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3851

@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4161

@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2479

@AutorestCI AutorestCI mentioned this pull request Dec 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 18, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3775

@lmazuel lmazuel assigned lmazuel and unassigned praries880 Dec 18, 2018
@lmazuel lmazuel removed the request for review from praries880 December 18, 2018 17:31
@blueww
Copy link
Member Author

blueww commented Dec 19, 2018

@lmazuel
I see the PR still in review.
Let me know if any action I need to take to make it merged.

@blueww blueww mentioned this pull request Dec 19, 2018
Merged
9 tasks
@williexu williexu mentioned this pull request Dec 19, 2018
Merged
2 tasks
@lmazuel lmazuel merged commit a1aae61 into Azure:master Dec 21, 2018
@kpajdzik kpajdzik removed the review label Dec 21, 2018
@jhendrixMSFT jhendrixMSFT mentioned this pull request Jan 8, 2019
Closed
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@blueww @AnuTalluri
[Storage] Fix the UseSubDomainName (Azure#4938)
73ab15a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

Assignees

@lmazuel lmazuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blueww @AutorestCI @azuresdkci @lmazuel @praries880 @kpajdzik