Adding Validations to asazure.json #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarzavery
reviewed
Sep 28, 2016
| "in": "path", | ||
| "required": true, | ||
| "type": "string", | ||
| "pattern": "^[-\\w\\._]+$", |
There was a problem hiding this comment.
"pattern": "^[-\\w\\._\\(\\)]+$",
There was a problem hiding this comment.
@amarzavery We should standardize this and make it part of good patterns/the skeleton Swagger file I'm working on.
There was a problem hiding this comment.
It would be nice to define commonly used model definitions and parameters in a common file and ask everyone to reference from there. That makes things consistent.
- regex for resource group - "resourceType" is acutally just "type" and can be moved t base type "resource" - "serverAdministrators" is "asAdministrators"
|
No modification for NodeJS |
|
No modification for Ruby |
|
No modification for Python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding validations to resourcegroupname and analysisservername