-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add a new api and add 2020-02-02-preview versions #9710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-go
|
azure-sdk-for-java
|
azure-sdk-for-net
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/disableAzureADOnlyAuthentication' removed or restructured? Old: Microsoft.Sql/preview/2019-06-01-preview/ServerAzureADAdministrators.json#L238:5 |
1029 - ReadonlyPropertyChanged |
The read only property has changed from 'false' to 'true'. New: Microsoft.Sql/preview/2019-06-01-preview/ServerAzureADAdministrators.json#L275:9 Old: Microsoft.Sql/preview/2019-06-01-preview/ServerAzureADAdministrators.json#L317:9 |
1029 - ReadonlyPropertyChanged |
The read only property has changed from 'false' to 'true'. New: Microsoft.Sql/preview/2019-06-01-preview/ServerAzureADAdministrators.json#L275:9 Old: Microsoft.Sql/preview/2019-06-01-preview/ServerAzureADAdministrators.json#L317:9 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
Azure Pipelines successfully started running 1 pipeline(s). |
A parameter is changed to read-only, this parameter was not in use before by customers, so we are not making any breaking change for customer. |
…into amagarwaAADOnly
No commit pushedDate could be found for PR 9710 in repo Azure/azure-rest-api-specs |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Jul 2, 2020
pilor
suggested changes
Jul 2, 2020
...l/resource-manager/Microsoft.Sql/preview/2020-02-02-preview/ServerAzureADAdministrators.json
Outdated
Show resolved
Hide resolved
…into amagarwaAADOnly
No commit pushedDate could be found for PR 9710 in repo Azure/azure-rest-api-specs |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
pilor
suggested changes
Jul 23, 2020
...ource-manager/Microsoft.Sql/preview/2020-02-02-preview/ServerAzureADOnlyAuthentications.json
Show resolved
Hide resolved
...ource-manager/Microsoft.Sql/preview/2020-02-02-preview/ServerAzureADOnlyAuthentications.json
Show resolved
Hide resolved
akning-ms
reviewed
Jul 24, 2020
...l/resource-manager/Microsoft.Sql/preview/2019-06-01-preview/ServerAzureADAdministrators.json
Show resolved
Hide resolved
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Add a new api and add 2020-02-02-preview versions * Fix get and list example files. * Remove 2019 api version from composite and update examples to 2020 api version. * Create a new AzureADOnlyAuthentications api and remove enable\disable apis. * update readme file. * remove blank line and other azureADOnlyAuthentication parameter from aad admin api. * Add missing curly braces and parameters. * fix typo * Prettier fixes * Fix more prettier issues. Co-authored-by: Amol Agarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
potential-sdk-breaking-change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.