Post release automated changes for containerregistry releases #18604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
jeremymeng
reviewed
Nov 9, 2021
| }, | ||
| "devDependencies": { | ||
| "typescript": "~4.2.0", | ||
| "typescript": "~4.4.0", |
There was a problem hiding this comment.
@praveenkuttappan do you know why this version is changed?
There was a problem hiding this comment.
dev-tool to update samples made this change.
There was a problem hiding this comment.
@witemple-msft explained that the dev-tool is using the version of typescript from dev-tool's deps. There's a concern that samples may not work with newer version of typescript. I am reverting this change.
jeremymeng
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post release automated changes for azure-container-registry