[DataFactory]Deleted 8 files from Extemsions and Added maxRowPerFile/f… #15094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ileNamePrefix to tabular format settings
YalinLi0312
suggested changes
Sep 11, 2020
There was a problem hiding this comment.
Hi @Jingshu923, do you have any reason to remove these source files? It looks like a potential breaking change.
@YalinLi0312 Yes, I will update the swagger project later, these files will generate code into Models dic. |
|
@Jingshu923 Thanks for your response. Please reference the PR for updating the swagger here, after it gets merged I can start to review this PR. |
|
@YalinLi0312 If I update swagger first, there will be some errors on .net sdk test, some models which I deleted in this PR will be conflicted. Could not I merge this PR first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added maxRowPerFile/fileNamePrefix to tabular format settings: [Data Factory]Add maxRowPerFile/fileNamePrefix to tabular format settings azure-rest-api-specs#10666
Deleted 8 files from Extemsions folder