[Core] Fix ignored retry_backoff_max in RetryPolicies #42444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Van Eck <[email protected]>
8cdff58 to
5cdcd12
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the retry_backoff_max parameter in RetryPolicy and AsyncRetryPolicy constructors was being ignored. The fix ensures that user-specified maximum backoff values are properly respected instead of always using the default class constant.
- Changed the
configure_retriesmethod to use the instance'sbackoff_maxproperty instead of the class constantBACKOFF_MAX - Updated the changelog to document this bug fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/core/azure-core/azure/core/pipeline/policies/_retry.py | Fixed the configure_retries method to use instance backoff_max instead of class constant |
| sdk/core/azure-core/CHANGELOG.md | Added changelog entry documenting the bug fix |
kashifkhan
reviewed
Aug 11, 2025
Signed-off-by: Paul Van Eck <[email protected]>
kashifkhan
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the
retry_backoff_maxparameter inRetryPolicyandAsyncRetryPolicyconstructors was being ignored, causing retry operations to use default maximum backoff values instead of the user-specified limits.