CryptographyClient implemented with service calls #6537
Merged
+3,495
−425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
/azp run python - client - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
f0cd317 to
36f585c
Compare
schaabs
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
async properties... what an age to be alive.
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/aio/client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/client.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6318, closes #6588 with a design for
CryptographyClient; closes #5648, closes #6592, closes #6688 with implementations delegating all operations to the service. Also closes #6319 by migrating track 1 tests. This PR sets my personal record for number of issues closed.