Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Naming conventions - linting #16455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 76 commits into from
May 2, 2025
Merged

Naming conventions - linting #16455

merged 76 commits into from
May 2, 2025

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Apr 7, 2025 •
edited
Loading

If you have any questions, contact me!

Draft to give everyone time to review and present me with questions.

NOTE - lint currently fails due to javascript out of heap memory. The last few commits are just attempts to get the CI to play nicely. Once I have the solution I will clean the config file and the command running eslint

RaananW added 30 commits February 24, 2025 17:16
@RaananW
update naming conventions and method names for consistency
6ab0cb5
@RaananW
fix: disable naming convention linting for specific interfaces and enums
5861be5
@RaananW
Merge remote-tracking branch 'upstream/master' into namingStandard
acb1b81
@RaananW
Continue with eslint naming stuff!
9089342
@RaananW
some more linting work linting
afebad2
@RaananW
refactor: replace Array constructors with array literals for better r…
e64b818 
…eadability
@RaananW
More linting work
583deb7
@RaananW
Adjusting rules
d3a34e0
@RaananW
fix linting rule
f95fa2a
@RaananW
More linting
0043066
@RaananW
Auto-fixable
2ebfa4f
@RaananW
Slowly getting there...
d66c325
@RaananW
further adjustments
0e6eaf7
@RaananW
adjusting config
92b5ff7
@RaananW
Merge remote-tracking branch 'upstream/master' into namingStandard
6d5d016
@RaananW
turn off some stuff
093a8da
@RaananW
update package lock
e6f28cc
@RaananW
Linting is fun!
46fd307
@RaananW
linting linting linting
6643443
@RaananW
a rolling linting fun
2c2aea4
@RaananW
Yeah!
7573314
@RaananW
back to normal
6e83e48
@RaananW
some fixes
7ff47d6
@RaananW
some mroe fixes
0eac3be
@RaananW
unneeded code removal
fd6cdc1
@RaananW
Merge remote-tracking branch 'upstream/master' into namingStandard
17598ba
@RaananW
fixing some stuff
79d6dd4
@RaananW
Starting linting GUI
3d0d765
@RaananW
GUI done
c1668b3
@RaananW
auto-fixes dev folder
540b423
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16455/merge/testResults/webgpuplaywright/index.html

@RaananW RaananW marked this pull request as ready for review April 30, 2025 18:37
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

You have made possible changes to one or more graph tools. To test the snapshots:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/nodeEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/nodeGeometryEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/nodeRenderGraphEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/guiEditor/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16455/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16455/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16455/merge/?snapshot=refs/pull/16455/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16455/merge/testResults/audioV2/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16455/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16455/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16455/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

You have made possible changes to one or more graph tools. To test the snapshots:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/nodeEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/nodeGeometryEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/nodeRenderGraphEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/guiEditor/

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16455/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16455/merge/?snapshot=refs/pull/16455/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16455/merge/testResults/audioV2/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16455/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 30, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16455/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16455/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16455/merge/?snapshot=refs/pull/16455/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

You have made possible changes to one or more graph tools. To test the snapshots:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/nodeEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/nodeGeometryEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/nodeRenderGraphEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16455/merge/guiEditor/

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16455/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

Audio test results:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16455/merge/testResults/audioV2/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16455/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16455/merge/testResults/webgl2playwright/index.html

@RaananW RaananW merged commit 8f5816d into BabylonJS:master May 2, 2025
19 checks passed
@RaananW RaananW deleted the namingStandard branch May 2, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantrem ryantrem ryantrem left review comments

@sebavan sebavan sebavan left review comments

@bghgary bghgary bghgary left review comments

@docEdub docEdub docEdub left review comments

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RaananW @bjsplat @deltakosh @ryantrem @sebavan @bghgary @docEdub